langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #3670] chore(langgraph): fix typing of task decorator #3417

New Issue
Closed
opened 2026-02-20 17:48:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:48:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/3670

State: closed
Merged: Yes

An async function of the form def foo(P) -> T has type Callable[[P], Awaitable[T]]. The old type annotations then converted the function into a Callable[[P], SyncAsyncFuture[Awaitable[T]]] which is incorrect.

The change introduced in this commit updates the type annotations to ensure the Awaitable[T] is correctly unwrapped.

I've tested it locally and confirmed it work on:

@task 
def sync_fn(a: int) -> int: ...

@task 
def async_fn(a: int) -> int: ...

Let me know if you want me to add tests, just let me know how you test type annotations.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/3670 **State:** closed **Merged:** Yes --- An async function of the form `def foo(P) -> T` has type `Callable[[P], Awaitable[T]]`. The old type annotations then converted the function into a `Callable[[P], SyncAsyncFuture[Awaitable[T]]]` which is incorrect. The change introduced in this commit updates the type annotations to ensure the `Awaitable[T]` is correctly unwrapped. I've tested it locally and confirmed it work on: ```python @task def sync_fn(a: int) -> int: ... @task def async_fn(a: int) -> int: ... ``` Let me know if you want me to add tests, just let me know how you test type annotations.
yindo added the pull-request label 2026-02-20 17:48:34 -05:00
yindo closed this issue 2026-02-20 17:48:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#3417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?