langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #3700] Refactor prepare_single_task to reduce cyclomatic complexity #3430

New Issue
Closed
opened 2026-02-20 17:48:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:48:35 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/3700

State: closed
Merged: No

This pull request refactors the prepare_single_task function located in ./libs/langgraph/langgraph/pregel. Previously, the function had a very high cyclomatic complexity (scoring an F according to radon), making it hard to maintain and understand.

To address this, I have:

  • Divided the function into smaller, focused helper subfunctions.
  • Collapsed and simplified complex and nested if-statements.
  • Streamlined the overall logic without affecting the functionality.

These changes have improved the complexity rating from F to A. The refactor has been performed solely to improve code readability and maintainability, and the behavior of the function remains unchanged.

Please review the changes.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/3700 **State:** closed **Merged:** No --- This pull request refactors the `prepare_single_task` function located in `./libs/langgraph/langgraph/pregel`. Previously, the function had a very high cyclomatic complexity (scoring an F according to radon), making it hard to maintain and understand. To address this, I have: - Divided the function into smaller, focused helper subfunctions. - Collapsed and simplified complex and nested if-statements. - Streamlined the overall logic without affecting the functionality. These changes have improved the complexity rating from F to A. The refactor has been performed solely to improve code readability and maintainability, and the behavior of the function remains unchanged. Please review the changes.
yindo added the pull-request label 2026-02-20 17:48:35 -05:00
yindo closed this issue 2026-02-20 17:48:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#3430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?