langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #3850] docs: fix typo in hil how to doc #3505

New Issue
Closed
opened 2026-02-20 17:48:43 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:48:43 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/3850

State: closed
Merged: Yes

Current text in the doc is incorrect:

Use the search tool to ask the user where they are, then look up the weather there

The search tool is not the one to use. Instead should just tell the model to ask the user.

In addition, an important step is missing and makes the code seem less impactful:

location = interrupt("Please provide your location:")

The question to ask the human is actually coming from the LLM, there is no need to hardcode it:

...
location = interrupt(ask.question)

Before merging, someone who validates this should push an update to cell outputs. I cleared it out from my branch because it made too many updates to the file and would make it harder to review.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/3850 **State:** closed **Merged:** Yes --- Current text in the doc is incorrect: ``` Use the search tool to ask the user where they are, then look up the weather there ``` The search tool is not the one to use. Instead should just tell the model to ask the user. In addition, an important step is missing and makes the code seem less impactful: ```python location = interrupt("Please provide your location:") ``` The question to ask the human is actually coming from the LLM, there is no need to hardcode it: ```python ... location = interrupt(ask.question) ``` Before merging, someone who validates this should push an update to cell outputs. I cleared it out from my branch because it made too many updates to the file and would make it harder to review.
yindo added the pull-request label 2026-02-20 17:48:43 -05:00
yindo closed this issue 2026-02-20 17:48:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#3505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?