langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #5145] feat: add Windows runner to lint CI #4265

New Issue
Closed
opened 2026-02-20 17:49:55 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:49:55 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/5145

State: closed
Merged: No

#5029

📋 Summary

This PR adds Windows CI support to the core testing and linting workflows while maintaining full compatibility with Makefile definitions.

🎯 Motivation

  • Early Detection 🐛: Catch Windows-specific build and test failures before they reach users. refs https://github.com/langchain-ai/langgraph/issues/3832
  • Cross-Platform Compatibility 🌍: Ensure LangGraph works seamlessly across all major operating systems
  • Developer Experience 💻: Windows developers can contribute with confidence that their changes won't break on other platforms

🔄 Changes

Modified Workflows

  • _lint.yml - Added Windows runner for linting checks
  • _test.yml - Extended unit tests to run on Windows
  • _test_langgraph.yml - Added Windows support for LangGraph-specific tests

Key Updates

  • ✅ Unified workflows to support both Ubuntu and Windows runners
  • ✅ Maintained existing make command usage for consistency
  • ✅ No changes to actual test/lint logic - only CI configuration

🔧 Technical Implementation

Windows Setup

  • Uses msys2/setup-msys2@v2 action with MINGW64 environment
  • Provides necessary tools for make command execution
  • Configured with path-type: inherit for seamless tool compatibility
  • All workflows use identical commands: make lint, make test, and make test_parallel

OS-Specific Steps

  • Separate setup steps for Ubuntu (apt-get) and Windows (MSYS2)
  • Conditional execution based on matrix.os for optimal performance
  • Shared test execution logic across both platforms

📊 Impact Analysis

  • Breaking Changes: None ❌

✅ Testing

  • 🔄 Current Status: Awaiting PR approval to run Windows CI

🎉 Benefits

  • Improved Reliability 🛡️: Catch platform-specific issues early
  • Broader Compatibility 🌐: Official Windows support for contributors
  • Consistent Development 🔄: Same commands work across all platforms
  • Future-Proof 🔮: Foundation for expanding Windows support

💬 Notes for Reviewers

  • The MSYS2 setup is the recommended approach for Windows CI with make support
  • No changes to the actual codebase - this is purely CI configuration
  • Happy to split this into smaller PRs if preferred 😊

Let me know if you have any questions or concerns! 🙏

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/5145 **State:** closed **Merged:** No --- #5029 ## 📋 Summary This PR adds Windows CI support to the core testing and linting workflows while maintaining full compatibility with Makefile definitions. ## 🎯 Motivation - **Early Detection** 🐛: Catch Windows-specific build and test failures before they reach users. refs https://github.com/langchain-ai/langgraph/issues/3832 - **Cross-Platform Compatibility** 🌍: Ensure LangGraph works seamlessly across all major operating systems - **Developer Experience** 💻: Windows developers can contribute with confidence that their changes won't break on other platforms ## 🔄 Changes ### Modified Workflows - `_lint.yml` - Added Windows runner for linting checks - `_test.yml` - Extended unit tests to run on Windows - `_test_langgraph.yml` - Added Windows support for LangGraph-specific tests ### Key Updates - ✅ Unified workflows to support both Ubuntu and Windows runners - ✅ Maintained existing `make` command usage for consistency - ✅ No changes to actual test/lint logic - only CI configuration ## 🔧 Technical Implementation ### Windows Setup - Uses `msys2/setup-msys2@v2` action with MINGW64 environment - Provides necessary tools for `make` command execution - Configured with `path-type: inherit` for seamless tool compatibility - All workflows use identical commands: `make lint`, `make test`, and `make test_parallel` ### OS-Specific Steps - Separate setup steps for Ubuntu (apt-get) and Windows (MSYS2) - Conditional execution based on `matrix.os` for optimal performance - Shared test execution logic across both platforms ## 📊 Impact Analysis - **Breaking Changes**: None ❌ ## ✅ Testing - 🔄 **Current Status**: Awaiting PR approval to run Windows CI ## 🎉 Benefits - **Improved Reliability** 🛡️: Catch platform-specific issues early - **Broader Compatibility** 🌐: Official Windows support for contributors - **Consistent Development** 🔄: Same commands work across all platforms - **Future-Proof** 🔮: Foundation for expanding Windows support ## 💬 Notes for Reviewers - The MSYS2 setup is the recommended approach for Windows CI with make support - No changes to the actual codebase - this is purely CI configuration - Happy to split this into smaller PRs if preferred 😊 --- Let me know if you have any questions or concerns! 🙏
yindo added the pull-request label 2026-02-20 17:49:55 -05:00
yindo closed this issue 2026-02-20 17:49:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#4265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?