langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #5740] fix: Widen type annotations for dynamic models in create_react_agent #4619

New Issue
Closed
opened 2026-02-20 17:50:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:50:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/5740

State: closed
Merged: No

Fixes #5739

Update type annotations in create_react_agent to support dynamic models that return LanguageModelLike (including results of bind_tools()).

Changes

  • Updated type annotations in chat_agent_executor.py to use LanguageModelLike instead of BaseChatModel
  • Updated docstrings to reflect the broader type acceptance
  • Maintained backward compatibility with existing BaseChatModel returns

Motivation

bind_tools() returns a Runnable[LanguageModelInput, BaseMessage], which was previously not supported by the type annotations. This change allows dynamic model callables to return the result of bind_tools() while keeping existing functionality intact.

Verification

  • Formatting checks passed
  • Linting checks passed
  • All tests passed successfully

Fixes the type annotation constraint that previously prevented using models with bound tools in dynamic model callables.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/5740 **State:** closed **Merged:** No --- Fixes #5739 Update type annotations in `create_react_agent` to support dynamic models that return `LanguageModelLike` (including results of `bind_tools()`). ### Changes - Updated type annotations in `chat_agent_executor.py` to use `LanguageModelLike` instead of `BaseChatModel` - Updated docstrings to reflect the broader type acceptance - Maintained backward compatibility with existing `BaseChatModel` returns ### Motivation `bind_tools()` returns a `Runnable[LanguageModelInput, BaseMessage]`, which was previously not supported by the type annotations. This change allows dynamic model callables to return the result of `bind_tools()` while keeping existing functionality intact. ### Verification - Formatting checks passed - Linting checks passed - All tests passed successfully Fixes the type annotation constraint that previously prevented using models with bound tools in dynamic model callables.
yindo added the pull-request label 2026-02-20 17:50:29 -05:00
yindo closed this issue 2026-02-20 17:50:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#4619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?