langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #5853] test: add missing tests for before and limit params #4684

New Issue
Closed
opened 2026-02-20 17:50:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:50:35 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/5853

State: closed
Merged: No

Summary

Completes the TODO at libs/checkpoint-sqlite/tests/test_sqlite.py:119 by adding comprehensive test coverage for
before and limit parameters in SqliteSaver.list().

Changes

  • Added tests for limit parameter (restricts number of results)
  • Added tests for before parameter (pagination before specific checkpoint)
  • Added tests for combining both parameters
  • Uses 5 test checkpoints to verify pagination behavior

Testing

make format  # ✅ Code formatted
make lint    # ✅ No issues found
make test TEST=tests/test_sqlite.py::TestSqliteSaver::test_search  # ✅ Tests pass
**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/5853 **State:** closed **Merged:** No --- ## Summary Completes the TODO at `libs/checkpoint-sqlite/tests/test_sqlite.py:119` by adding comprehensive test coverage for `before` and `limit` parameters in `SqliteSaver.list()`. ## Changes - Added tests for `limit` parameter (restricts number of results) - Added tests for `before` parameter (pagination before specific checkpoint) - Added tests for combining both parameters - Uses 5 test checkpoints to verify pagination behavior ## Testing ```bash make format # ✅ Code formatted make lint # ✅ No issues found make test TEST=tests/test_sqlite.py::TestSqliteSaver::test_search # ✅ Tests pass
yindo added the pull-request label 2026-02-20 17:50:35 -05:00
yindo closed this issue 2026-02-20 17:50:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#4684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?