langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #5950] docs(examples/rag/langgraph_agentic_rag): Remove redundant format_docs helper in generate function #4742

New Issue
Closed
opened 2026-02-20 17:50:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:50:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/5950

State: closed
Merged: No

Description:
The generate function in the Agentic RAG workflow previously defined a format_docs helper to join document content. However, the documents passed to the function are already a single string returned by the retriever tool, and this helper function has never been used.

This PR:

  • Reduces confusion and improves code readability.
  • Removes the unused format_docs function.
  • Cleans up the generate function to directly use docs as context.

Changes:

  • generate function in edges.py (or wherever defined):
  • Removed the nested format_docs function.
  • Continue passing docs directly to rag_chain.invoke.

Why:

  • docs is already a string; no need to transform it further.
  • Simplifies the code and improves maintainability.
**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/5950 **State:** closed **Merged:** No --- Description: The generate function in the Agentic RAG workflow previously defined a format_docs helper to join document content. However, the documents passed to the function are already a single string returned by the retriever tool, and this helper function has never been used. This PR: - Reduces confusion and improves code readability. - Removes the unused format_docs function. - Cleans up the generate function to directly use docs as context. Changes: - generate function in edges.py (or wherever defined): - Removed the nested format_docs function. - Continue passing docs directly to rag_chain.invoke. Why: - docs is already a string; no need to transform it further. - Simplifies the code and improves maintainability.
yindo added the pull-request label 2026-02-20 17:50:40 -05:00
yindo closed this issue 2026-02-20 17:50:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#4742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?