langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #6509] fix(prebuilt): support generic type arguments for ToolRuntime injection #5084

New Issue
Closed
opened 2026-02-20 17:51:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:51:12 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/6509

State: closed
Merged: Yes

Description:
This PR fixes an issue where injection types (like ToolRuntime) were not recognized by ToolNode when used with generic type arguments (e.g., ToolRuntime[MyContext]).

Previously, the _is_injection check relied solely on isinstance and issubclass, which fail for typing._GenericAlias objects. This update adds a check using typing.get_origin() to correctly identify the base class of generic types, ensuring the runtime is injected correctly even when type hints are present.

Issue: Fixes #6465

Dependencies: None

Twitter handle: @SidharthRajmoh2

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/6509 **State:** closed **Merged:** Yes --- **Description:** This PR fixes an issue where injection types (like `ToolRuntime`) were not recognized by `ToolNode` when used with generic type arguments (e.g., `ToolRuntime[MyContext]`). Previously, the `_is_injection` check relied solely on `isinstance` and `issubclass`, which fail for `typing._GenericAlias` objects. This update adds a check using `typing.get_origin()` to correctly identify the base class of generic types, ensuring the runtime is injected correctly even when type hints are present. **Issue:** Fixes #6465 **Dependencies:** None **Twitter handle:** @SidharthRajmoh2
yindo added the pull-request label 2026-02-20 17:51:12 -05:00
yindo closed this issue 2026-02-20 17:51:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#5084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?