langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #6765] refactor: replace bare except with BaseException in AsyncQueue #5274

New Issue
Closed
opened 2026-02-20 17:51:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:51:28 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/6765

State: closed
Merged: Yes

Description

Replaced a bare except: with except BaseException: in libs/langgraph/langgraph/_internal/_queue.py.

Motivation

Using a bare except: violates PEP 8 (E722). While functionally equivalent to except BaseException:, making it explicit improves code readability and satisfies static analysis tools.

This ensures that asyncio.CancelledError (which inherits from BaseException) is still caught and handled correctly by the cancellation logic in the wait() method, but without the ambiguity of a bare except.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/6765 **State:** closed **Merged:** Yes --- ## Description Replaced a bare `except:` with `except BaseException:` in `libs/langgraph/langgraph/_internal/_queue.py`. ## Motivation Using a bare `except:` violates PEP 8 (E722). While functionally equivalent to `except BaseException:`, making it explicit improves code readability and satisfies static analysis tools. This ensures that `asyncio.CancelledError` (which inherits from `BaseException`) is still caught and handled correctly by the cancellation logic in the `wait()` method, but without the ambiguity of a bare except.
yindo added the pull-request label 2026-02-20 17:51:28 -05:00
yindo closed this issue 2026-02-20 17:51:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#5274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?