langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #6783] fix(langgraph): validate config type before invoke and stream #5291

New Issue
Closed
opened 2026-02-20 17:51:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:51:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/6783

State: closed
Merged: No

Summary

Fixes #6782.

graph.invoke() / graph.stream() currently crash with an internal AttributeError when config is not a mapping (for example, a string).

This PR adds explicit config-type validation and returns a clear user-facing TypeError instead.

Changes

  • Add runtime validation in ensure_config(...):
    • raise TypeError("Expected config to be a mapping, got <type>") for non-mapping config values.
  • Normalize config earlier in both sync and async stream paths:
    • call ensure_config(self.config, config) before checking stream_mode defaults.
    • this prevents pre-validation access via config.get(...) on invalid types.
  • Add regression tests:
    • test_ensure_config_rejects_non_mapping
    • test_graph_rejects_non_mapping_config (covers both graph.invoke and graph.stream)

Validation

Executed locally in libs/langgraph:

  • make format
  • make lint
  • NO_DOCKER=true TEST=tests/test_utils.py make test
  • uv run python -m trace --count --coverdir /tmp/langgraph_6782_trace --module pytest tests/test_utils.py -q

The new failure path and stream/invoke guard paths are covered by the added tests.

AI involvement

AI assistance was limited to unit-test drafting, code-review suggestions, and formatting checks. Final implementation and code decisions were manually completed and verified.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/6783 **State:** closed **Merged:** No --- ## Summary Fixes #6782. `graph.invoke()` / `graph.stream()` currently crash with an internal `AttributeError` when `config` is not a mapping (for example, a string). This PR adds explicit config-type validation and returns a clear user-facing `TypeError` instead. ## Changes - Add runtime validation in `ensure_config(...)`: - raise `TypeError("Expected config to be a mapping, got <type>")` for non-mapping config values. - Normalize config earlier in both sync and async stream paths: - call `ensure_config(self.config, config)` before checking `stream_mode` defaults. - this prevents pre-validation access via `config.get(...)` on invalid types. - Add regression tests: - `test_ensure_config_rejects_non_mapping` - `test_graph_rejects_non_mapping_config` (covers both `graph.invoke` and `graph.stream`) ## Validation Executed locally in `libs/langgraph`: - `make format` - `make lint` - `NO_DOCKER=true TEST=tests/test_utils.py make test` - `uv run python -m trace --count --coverdir /tmp/langgraph_6782_trace --module pytest tests/test_utils.py -q` The new failure path and stream/invoke guard paths are covered by the added tests. ## AI involvement AI assistance was limited to unit-test drafting, code-review suggestions, and formatting checks. Final implementation and code decisions were manually completed and verified.
yindo added the pull-request label 2026-02-20 17:51:29 -05:00
yindo closed this issue 2026-02-20 17:51:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#5291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?