langchain-ai/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-07-15 12:35:43 -04:00
Code Issues 314 Packages Projects Releases 17 Wiki Activity

[PR #6825] fix(typing): accept TypedDict state schemas under ty checker #5319

New Issue
Open
opened 2026-02-20 17:51:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-20 17:51:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langchain-ai/langgraph/pull/6825

State: open
Merged: No

Summary

This PR fixes type-checking failures reported in #6823 when using ty with TypedDict state schemas.

What changed

  • Extended StateLike to include Mapping[str, Any] so TypedDict-based state schemas satisfy stricter type checkers like ty.
  • Kept the existing protocol-based constraints (TypedDictLikeV1, TypedDictLikeV2, DataclassLike, BaseModel) intact.
  • Added a regression test for total=False TypedDict state schemas in tests/test_type_checking.py.

Why this works

ty does not consistently treat TypedDict classes as satisfying the existing protocol-only bound. Including Mapping[str, Any] in the state bound provides a compatible path for TypedDict while still rejecting unsupported schema classes.

Validation

  • uv run ruff format langgraph/_internal/_typing.py tests/test_type_checking.py --check
  • uv run ruff check langgraph/_internal/_typing.py tests/test_type_checking.py
  • uv run mypy langgraph
  • NO_DOCKER=true uv run pytest tests/test_type_checking.py
  • uv run --with ty==0.0.17 ty check /tmp/langgraph_ty_6823_check.py

AI assistance disclosure: AI support was limited to test/lint command orchestration and drafting review text. Final code changes and validation decisions were manually reviewed before submission.

**Original Pull Request:** https://github.com/langchain-ai/langgraph/pull/6825 **State:** open **Merged:** No --- ## Summary This PR fixes type-checking failures reported in #6823 when using `ty` with `TypedDict` state schemas. ### What changed - Extended `StateLike` to include `Mapping[str, Any]` so `TypedDict`-based state schemas satisfy stricter type checkers like `ty`. - Kept the existing protocol-based constraints (`TypedDictLikeV1`, `TypedDictLikeV2`, `DataclassLike`, `BaseModel`) intact. - Added a regression test for `total=False` TypedDict state schemas in `tests/test_type_checking.py`. ## Why this works `ty` does not consistently treat `TypedDict` classes as satisfying the existing protocol-only bound. Including `Mapping[str, Any]` in the state bound provides a compatible path for `TypedDict` while still rejecting unsupported schema classes. ## Validation - `uv run ruff format langgraph/_internal/_typing.py tests/test_type_checking.py --check` - `uv run ruff check langgraph/_internal/_typing.py tests/test_type_checking.py` - `uv run mypy langgraph` - `NO_DOCKER=true uv run pytest tests/test_type_checking.py` - `uv run --with ty==0.0.17 ty check /tmp/langgraph_ty_6823_check.py` AI assistance disclosure: AI support was limited to test/lint command orchestration and drafting review text. Final code changes and validation decisions were manually reviewed before submission.
yindo added the pull-request label 2026-02-20 17:51:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agents
awaiting author revision
bug
change
chat models
checkpointer
ci
code quality
code quality
dependencies
documentation
drawing
duplicate
enhancement
good first issue
help wanted
invalid
maintainer
meta
missing information
not maintained by langchain
open-swe-auto
open-swe-max
open-swe-max-auto
pending
performance
pull-request
Mirrored from GitHub Pull Request
 question
requires design
sdk
server
stale
studio
tests
type checking
usage question
v0.5
v1.1
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraph#5319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?