langchain-ai/langgraphjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraphjs.git synced 2026-07-23 09:35:22 -04:00
Code Issues 108 Packages Projects Releases 20 Wiki Activity

[PR #1100] [CLOSED] Fix: Check entire error object in isGraphInterrupt instead of just name property #1234

New Issue
Closed
opened 2026-02-15 19:17:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 19:17:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraphjs/pull/1100
Author: @se1ch
Created: 4/11/2025
Status: ❌ Closed

Base: main ← Head: fix-isgraphinterrupt-check

📄 Description

Description

Changed the argument passed to the isGraphInterrupt function in the error handling section of the run method in the ToolNode class.

Before: isGraphInterrupt(e.name)
After: isGraphInterrupt(e)

Rationale

The current implementation passes only the name property of the error object to the isGraphInterrupt function, but the actual function implementation expects the complete error object.

The isGraphInterrupt function, defined in errors.js, is designed to take the error object itself as an argument and examine its type and attributes. By examining the entire error object rather than just its name property, we can more accurately identify graph interruptions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraphjs/pull/1100 **Author:** [@se1ch](https://github.com/se1ch) **Created:** 4/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-isgraphinterrupt-check` --- ### 📄 Description ## Description Changed the argument passed to the `isGraphInterrupt` function in the error handling section of the `run` method in the `ToolNode` class. Before: `isGraphInterrupt(e.name)` After: `isGraphInterrupt(e)` ## Rationale The current implementation passes only the `name` property of the error object to the `isGraphInterrupt` function, but the actual function implementation expects the complete error object. The `isGraphInterrupt` function, defined in `errors.js`, is designed to take the error object itself as an argument and examine its type and attributes. By examining the entire error object rather than just its `name` property, we can more accurately identify graph interruptions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 19:17:45 -05:00
yindo closed this issue 2026-02-15 19:17:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
checkpointer
docs-needed
documentation
enhancement
good first issue
good writeup
help wanted
invalid
langgraph-supervisor
open-swe-auto
platform
prebuilt
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraphjs#1234
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?