langchain-ai/langgraphjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraphjs.git synced 2026-07-23 01:26:57 -04:00
Code Issues 108 Packages Projects Releases 20 Wiki Activity

[PR #1404] [MERGED] fix(langgraph): dispose unused combined signals #1436

New Issue
Closed
opened 2026-02-15 20:15:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 20:15:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraphjs/pull/1404
Author: @dqbd
Created: 7/16/2025
Status: ✅ Merged
Merged: 7/16/2025
Merged by: @dqbd

Base: main ← Head: dqbd/abort-signal-listener-optimization

📝 Commits (2)

  • a2477c0 fix(langgraph): dispose unused combined signals
  • 5f02d42 Add changeset

📊 Changes

6 files changed (+223 additions, -237 deletions)

View changed files

➕ .changeset/olive-bottles-study.md (+5 -0)
📝 libs/langgraph/src/pregel/index.ts (+4 -6)
📝 libs/langgraph/src/pregel/runner.ts (+51 -64)
📝 libs/langgraph/src/pregel/types.ts (+0 -5)
📝 libs/langgraph/src/pregel/utils/index.ts (+19 -11)
📝 libs/langgraph/src/tests/pregel/pregel.cancellation.test.ts (+144 -151)

📄 Description

  • Avoids hidden chaining of combined abort signals with external signal, thus attaching a listener on each tick.
  • Make sure to always remove the event listener on external abort signal when the combined signal is not used anymore

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraphjs/pull/1404 **Author:** [@dqbd](https://github.com/dqbd) **Created:** 7/16/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@dqbd](https://github.com/dqbd) **Base:** `main` ← **Head:** `dqbd/abort-signal-listener-optimization` --- ### 📝 Commits (2) - [`a2477c0`](https://github.com/langchain-ai/langgraphjs/commit/a2477c0a7e4fb7ce9afbc69902908a44a8f6e8b4) fix(langgraph): dispose unused combined signals - [`5f02d42`](https://github.com/langchain-ai/langgraphjs/commit/5f02d421279c2da58076a96d31b912e22e607219) Add changeset ### 📊 Changes **6 files changed** (+223 additions, -237 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/olive-bottles-study.md` (+5 -0) 📝 `libs/langgraph/src/pregel/index.ts` (+4 -6) 📝 `libs/langgraph/src/pregel/runner.ts` (+51 -64) 📝 `libs/langgraph/src/pregel/types.ts` (+0 -5) 📝 `libs/langgraph/src/pregel/utils/index.ts` (+19 -11) 📝 `libs/langgraph/src/tests/pregel/pregel.cancellation.test.ts` (+144 -151) </details> ### 📄 Description - Avoids hidden chaining of combined abort signals with external signal, thus attaching a listener on each tick. - Make sure to always remove the event listener on external abort signal when the combined signal is not used anymore --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 20:15:45 -05:00
yindo closed this issue 2026-02-15 20:15:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
checkpointer
docs-needed
documentation
enhancement
good first issue
good writeup
help wanted
invalid
langgraph-supervisor
open-swe-auto
platform
prebuilt
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraphjs#1436
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?