langchain-ai/langgraphjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraphjs.git synced 2026-07-21 16:45:24 -04:00
Code Issues 108 Packages Projects Releases 20 Wiki Activity

Bug in checkpoint id generation when converting UUID v1 to UUID v6. #41

New Issue
Closed
opened 2026-02-15 17:06:01 -05:00 by yindo · 3 comments
yindo commented 2026-02-15 17:06:01 -05:00
Owner
Copy Link
Copy Source

Originally created by @chentschel on GitHub (Jun 27, 2024).

When the graph is generating a UUID v6 from the starting point the generated id looks like : 6fbb4270-3461-11ef-undefineda0-a9b17340a0aa.

Note the 'undefined' in the UUID generated.

This happens because the code used to generate the id is called with a negative number. (-1) when the graph does not have previous checkpoints.

UUID v1 to generate the ID here: https://github.com/langchain-ai/langgraphjs/blob/main/langgraph/src/checkpoint/id.ts#L30

After the v1 generation, there is a conversion to a UUID v6. It be easy to solve if the use uuid v6, from start. A proposed code bellow.

function uuid6(clockseq: number) {
  // using uuid pkg
  const node = crypto.getRandomValues(new Uint8Array(6));

  return  v6({ node, clockseq });
}

@nfcampos ?

Originally created by @chentschel on GitHub (Jun 27, 2024). When the graph is generating a UUID v6 from the starting point the generated id looks like : `6fbb4270-3461-11ef-undefineda0-a9b17340a0aa`. Note the 'undefined' in the UUID generated. This happens because the code used to generate the `id` is called with a negative number. (-1) when the graph does not have previous checkpoints. UUID v1 to generate the ID here: https://github.com/langchain-ai/langgraphjs/blob/main/langgraph/src/checkpoint/id.ts#L30 After the v1 generation, there is a conversion to a UUID v6. It be easy to solve if the use uuid v6, from start. A proposed code bellow. ``` function uuid6(clockseq: number) { // using uuid pkg const node = crypto.getRandomValues(new Uint8Array(6)); return v6({ node, clockseq }); } ``` @nfcampos ?
yindo closed this issue 2026-02-15 17:06:01 -05:00
yindo commented 2026-02-15 17:14:54 -05:00
Author
Owner
Copy Link
Copy Source

@nfcampos commented on GitHub (Jun 27, 2024):

how do we know v6 function doesn't have the same issue?
\

@nfcampos commented on GitHub (Jun 27, 2024): how do we know `v6` function doesn't have the same issue? \
yindo commented 2026-02-15 17:14:54 -05:00
Author
Owner
Copy Link
Copy Source

@chentschel commented on GitHub (Jun 27, 2024):

I tried in a separate script.

Also preferably , it would be good to use v7 instead of v6 . Is that ok
with you?

https://www.ietf.org/archive/id/draft-peabody-dispatch-new-uuid-format-04.html#name-uuid-version-7

CH

On Thu, 27 Jun 2024 at 8:17 PM Nuno Campos @.***> wrote:

how do we know v6 function doesn't have the same issue?
\

—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/langgraphjs/issues/234#issuecomment-2195137104,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACN566AAPODCSD26EZBMD3ZJQ3JPAVCNFSM6AAAAABJ7O6PSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGEZTOMJQGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@chentschel commented on GitHub (Jun 27, 2024): I tried in a separate script. Also preferably , it would be good to use v7 instead of v6 . Is that ok with you? https://www.ietf.org/archive/id/draft-peabody-dispatch-new-uuid-format-04.html#name-uuid-version-7 CH On Thu, 27 Jun 2024 at 8:17 PM Nuno Campos ***@***.***> wrote: > how do we know v6 function doesn't have the same issue? > \ > > — > Reply to this email directly, view it on GitHub > <https://github.com/langchain-ai/langgraphjs/issues/234#issuecomment-2195137104>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACN566AAPODCSD26EZBMD3ZJQ3JPAVCNFSM6AAAAABJ7O6PSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGEZTOMJQGQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >
yindo commented 2026-02-15 17:14:55 -05:00
Author
Owner
Copy Link
Copy Source

@nfcampos commented on GitHub (Jun 27, 2024):

Thanks I'm going to merge the PR linked above. We use v6 as it supports a clock seq field, which we use to ensure checkpoint ids monodically increase with step number

@nfcampos commented on GitHub (Jun 27, 2024): Thanks I'm going to merge the PR linked above. We use v6 as it supports a clock seq field, which we use to ensure checkpoint ids monodically increase with step number
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
checkpointer
docs-needed
documentation
enhancement
good first issue
good writeup
help wanted
invalid
langgraph-supervisor
open-swe-auto
platform
prebuilt
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraphjs#41
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?