langchain-ai/langgraphjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraphjs.git synced 2026-07-21 16:45:24 -04:00
Code Issues 108 Packages Projects Releases 20 Wiki Activity

Rewoo example wrong array destructure in toolExecution? #69

New Issue
Closed
opened 2026-02-15 17:15:22 -05:00 by yindo · 1 comment
yindo commented 2026-02-15 17:15:22 -05:00
Owner
Copy Link
Copy Source

Originally created by @maciejNisztuk on GitHub (Aug 20, 2024).

In the Rewoo example code in the toolExecution function in the line:
const [, stepName, tool, , toolInputTemplate] = state.steps[_step - 1];
the toolInputTemplate variable is assigned the entire matching string, not the tool input. I think the line should look like this:
const [, stepName, tool, toolInputTemplate] = state.steps[_step - 1];

Originally created by @maciejNisztuk on GitHub (Aug 20, 2024). In the Rewoo example code in the toolExecution function in the line: ` const [, stepName, tool, , toolInputTemplate] = state.steps[_step - 1]; ` the toolInputTemplate variable is assigned the entire matching string, not the tool input. I think the line should look like this: `const [, stepName, tool, toolInputTemplate] = state.steps[_step - 1]; `
yindo closed this issue 2026-02-15 17:15:22 -05:00
yindo commented 2026-02-15 17:15:22 -05:00
Author
Owner
Copy Link
Copy Source

@bracesproul commented on GitHub (Aug 22, 2024):

Thank you for flagging this! I just checked and you're correct. It looks like reason it worked before is the last element in the array it was extracting included the tool input, but also had extra content which was irrelevant. This change should harden the graph for future runs.

PR here

@bracesproul commented on GitHub (Aug 22, 2024): Thank you for flagging this! I just checked and you're correct. It looks like reason it worked before is the last element in the array it was extracting included the tool input, but also had extra content which was irrelevant. This change should harden the graph for future runs. [PR here](https://github.com/langchain-ai/langgraphjs/pull/345)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
checkpointer
docs-needed
documentation
enhancement
good first issue
good writeup
help wanted
invalid
langgraph-supervisor
open-swe-auto
platform
prebuilt
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraphjs#69
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?