langchain-ai/langgraphjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraphjs.git synced 2026-07-21 16:45:24 -04:00
Code Issues 108 Packages Projects Releases 20 Wiki Activity

ToolExecutor should probably use an array of StructuredTool instances rather than Tool instances #7

New Issue
Closed
opened 2026-02-15 17:05:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:05:12 -05:00
Owner
Copy Link
Copy Source

Originally created by @zeropaper on GitHub (Feb 1, 2024).

While trying to use a DynamicStructuredTool instance with a ToolExecutor, I noticed that TS was yelling at me.

const tools = [
  new DynamicStructuredTool({
    name: "search",
    description: "Search the web",
    schema: z.object({
      input: z.string(),
    }),
    callbacks: [toolRunCollector],
    async func({ input }, runManager) {
      console.log("searching for", input);
      return Promise.resolve("whatever");
    },
  }),
];

const toolExecutor = new ToolExecutor({
  tools // TypeScript is yelling at me here
});

I suspect that the ToolExecutorArgs interface should be:

https://github.com/langchain-ai/langgraphjs/blob/8ee245f992443c8d7efc0b505451a6cd5cc75504/langgraph/src/prebuilt/tool_executor.ts#L10-L16

import { StructuredTool } from "@langchain/core/tools";
// ...
export interface ToolExecutorArgs {
    tools: Array<StructuredTool>;
    /**
     * @default {INVALID_TOOL_MSG_TEMPLATE}
     */
    invalidToolMsgTemplate?: string;
}

As Tool extends StructuredTool (which is quite weird in my book).

Originally created by @zeropaper on GitHub (Feb 1, 2024). While trying to use a `DynamicStructuredTool` instance with a `ToolExecutor`, I noticed that TS was yelling at me. ```ts const tools = [ new DynamicStructuredTool({ name: "search", description: "Search the web", schema: z.object({ input: z.string(), }), callbacks: [toolRunCollector], async func({ input }, runManager) { console.log("searching for", input); return Promise.resolve("whatever"); }, }), ]; const toolExecutor = new ToolExecutor({ tools // TypeScript is yelling at me here }); ``` I suspect that the `ToolExecutorArgs` interface should be: https://github.com/langchain-ai/langgraphjs/blob/8ee245f992443c8d7efc0b505451a6cd5cc75504/langgraph/src/prebuilt/tool_executor.ts#L10-L16 ```ts import { StructuredTool } from "@langchain/core/tools"; // ... export interface ToolExecutorArgs { tools: Array<StructuredTool>; /** * @default {INVALID_TOOL_MSG_TEMPLATE} */ invalidToolMsgTemplate?: string; } ``` As [`Tool` extends `StructuredTool`](https://api.js.langchain.com/classes/langchain_core_tools.StructuredTool.html) (which is quite weird in my book).
yindo closed this issue 2026-02-15 17:05:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
checkpointer
docs-needed
documentation
enhancement
good first issue
good writeup
help wanted
invalid
langgraph-supervisor
open-swe-auto
platform
prebuilt
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraphjs#7
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?