langchain-ai/langgraphjs
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraphjs.git synced 2026-07-22 00:55:26 -04:00
Code Issues 108 Packages Projects Releases 20 Wiki Activity

[PR #576] [CLOSED] fix(checkpoint-sqlite): fix invalid SQL syntax on list #862

New Issue
Closed
opened 2026-02-15 19:16:11 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 19:16:11 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langgraphjs/pull/576
Author: @benjamincburns
Created: 10/10/2024
Status: ❌ Closed

Base: main ← Head: fix-sqlitesaver-list-sql-bug

📝 Commits (1)

  • b2c7bb3 fix(checkpoint-sqlite): fix invalid SQL syntax on list

📊 Changes

1 file changed (+18 additions, -4 deletions)

View changed files

📝 libs/checkpoint-sqlite/src/index.ts (+18 -4)

📄 Description

Prior to this change, if no filters (including those defined by config.configurable) were passed to the SqliteSaver.list method, it would throw due to there being a WHERE keyword with an empty predicate list in the prepared SELECT query. This change builds the query iteratively to avoid this error.

This change also fixes a potential (albeit unlikely) SQL injection attack vector in the same query. Prior to this change, the limit value was being directly concatenated into the sql string, rather than being sanitized first.

Found while working on #541, thanks to this test.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langgraphjs/pull/576 **Author:** [@benjamincburns](https://github.com/benjamincburns) **Created:** 10/10/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-sqlitesaver-list-sql-bug` --- ### 📝 Commits (1) - [`b2c7bb3`](https://github.com/langchain-ai/langgraphjs/commit/b2c7bb31c1c38ac334a240f2db33efa1594cd64c) fix(checkpoint-sqlite): fix invalid SQL syntax on list ### 📊 Changes **1 file changed** (+18 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `libs/checkpoint-sqlite/src/index.ts` (+18 -4) </details> ### 📄 Description Prior to this change, if no filters (including those defined by `config.configurable`) were passed to the `SqliteSaver.list` method, it would throw due to there being a `WHERE` keyword with an empty predicate list in the prepared `SELECT` query. This change builds the query iteratively to avoid this error. This change also fixes a potential (albeit unlikely) SQL injection attack vector in the same query. Prior to this change, the `limit` value was being directly concatenated into the `sql` string, rather than being sanitized first. Found while working on #541, thanks to [this test](https://github.com/benjamincburns/langgraphjs/blob/d95f4aafac23d2f39c12a7c1c0a2f2ede0815ba8/libs/checkpoint-validation/src/tests/spec/list.ts#L148-L170). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 19:16:11 -05:00
yindo closed this issue 2026-02-15 19:16:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
checkpointer
docs-needed
documentation
enhancement
good first issue
good writeup
help wanted
invalid
langgraph-supervisor
open-swe-auto
platform
prebuilt
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langgraphjs#862
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?