langchain-ai/langserve
1
0
Fork 0
mirror of https://github.com/langchain-ai/langserve.git synced 2026-07-16 09:34:30 -04:00
Code Issues 136 Packages Projects Releases 10 Wiki Activity

[PR #134] [MERGED] Fix crash when mounting same chain twice in same app #370

New Issue
Closed
opened 2026-02-16 00:20:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 00:20:19 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langserve/pull/134
Author: @nfcampos
Created: 10/31/2023
Status: ✅ Merged
Merged: 10/31/2023
Merged by: @eyurtsev

Base: main ← Head: nc/fix-crash-when-mounting-same-chain-twice

📝 Commits (3)

📊 Changes

2 files changed (+8 additions, -9 deletions)

View changed files

📝 langserve/server.py (+7 -8)
📝 tests/unit_tests/test_server_client.py (+1 -1)

📄 Description

The crash was due to Config.configurable pydantic base model not being renamed, fixed by recursively renaming field annotations which are themselves base models

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langserve/pull/134 **Author:** [@nfcampos](https://github.com/nfcampos) **Created:** 10/31/2023 **Status:** ✅ Merged **Merged:** 10/31/2023 **Merged by:** [@eyurtsev](https://github.com/eyurtsev) **Base:** `main` ← **Head:** `nc/fix-crash-when-mounting-same-chain-twice` --- ### 📝 Commits (3) - [`2f47c52`](https://github.com/langchain-ai/langserve/commit/2f47c529d39a616710656eafdb63e5b5b9701b8d) Fix crash when mounting same chain twice in same app - [`19360c6`](https://github.com/langchain-ai/langserve/commit/19360c6b62188900f95ee4c256ddc8c8342fcc31) Lint - [`555494b`](https://github.com/langchain-ai/langserve/commit/555494bfd73ae6935a1f408caf2571449485f4e2) Update test ### 📊 Changes **2 files changed** (+8 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `langserve/server.py` (+7 -8) 📝 `tests/unit_tests/test_server_client.py` (+1 -1) </details> ### 📄 Description The crash was due to Config.configurable pydantic base model not being renamed, fixed by recursively renaming field annotations which are themselves base models --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 00:20:19 -05:00
yindo closed this issue 2026-02-16 00:20:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
enhancement
help wanted
in-progress
investigate
not langserve
playground
pull-request
Mirrored from GitHub Pull Request
 question
stale
streaming
unable-to-reproduce
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langserve#370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?