langchain-ai/langserve
1
0
Fork 0
mirror of https://github.com/langchain-ai/langserve.git synced 2026-07-16 09:34:30 -04:00
Code Issues 136 Packages Projects Releases 10 Wiki Activity

[PR #158] [MERGED] Fix bug in streaming associated with additive chunks #388

New Issue
Closed
opened 2026-02-16 00:20:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 00:20:23 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langserve/pull/158
Author: @eyurtsev
Created: 11/2/2023
Status: ✅ Merged
Merged: 11/2/2023
Merged by: @eyurtsev

Base: main ← Head: eugene/fix_client_error

📝 Commits (4)

📊 Changes

2 files changed (+105 additions, -21 deletions)

View changed files

📝 langserve/client.py (+49 -9)
📝 tests/unit_tests/test_server_client.py (+56 -12)

📄 Description

  • Fix issue in stream/astream endpoint associated with addable types

  • Have not been able to figure how to run sync unit tests yet with pytest:

    • fastapi app is async so there's an event loop that's created somewhere
    • within fastapi sse_starlette also deals with an event loop for the
      streaming endpoint
    • This results in a failure when running all unit tests together (https://github.com/sysid/sse-starlette/issues/68)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langserve/pull/158 **Author:** [@eyurtsev](https://github.com/eyurtsev) **Created:** 11/2/2023 **Status:** ✅ Merged **Merged:** 11/2/2023 **Merged by:** [@eyurtsev](https://github.com/eyurtsev) **Base:** `main` ← **Head:** `eugene/fix_client_error` --- ### 📝 Commits (4) - [`9d2daed`](https://github.com/langchain-ai/langserve/commit/9d2daed31bd44414e6c715ebb43ec55c6958bc03) x - [`815b388`](https://github.com/langchain-ai/langserve/commit/815b3885217647a0a6b2d35019f3759b9b92cc7e) x - [`2bf419e`](https://github.com/langchain-ai/langserve/commit/2bf419e0b6dfe20889a3e3f088df92324ebcd071) x - [`859f5ed`](https://github.com/langchain-ai/langserve/commit/859f5ed948595d184c6996f3d1f192e677a275df) x ### 📊 Changes **2 files changed** (+105 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `langserve/client.py` (+49 -9) 📝 `tests/unit_tests/test_server_client.py` (+56 -12) </details> ### 📄 Description - Fix issue in stream/astream endpoint associated with addable types - Have not been able to figure how to run sync unit tests yet with pytest: - fastapi app is async so there's an event loop that's created somewhere - within fastapi sse_starlette also deals with an event loop for the streaming endpoint - This results in a failure when running all unit tests together (https://github.com/sysid/sse-starlette/issues/68) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 00:20:23 -05:00
yindo closed this issue 2026-02-16 00:20:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
enhancement
help wanted
in-progress
investigate
not langserve
playground
pull-request
Mirrored from GitHub Pull Request
 question
stale
streaming
unable-to-reproduce
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langserve#388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?