langchain-ai/langserve
1
0
Fork 0
mirror of https://github.com/langchain-ai/langserve.git synced 2026-07-16 09:34:30 -04:00
Code Issues 136 Packages Projects Releases 10 Wiki Activity

[PR #216] [MERGED] remove eager mode on feedback #433

New Issue
Closed
opened 2026-02-16 00:20:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 00:20:31 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langserve/pull/216
Author: @jakerachleff
Created: 11/12/2023
Status: ✅ Merged
Merged: 11/16/2023
Merged by: @jakerachleff

Base: main ← Head: 2023-11-12-remove-eager-mode

📝 Commits (2)

📊 Changes

2 files changed (+16 additions, -57 deletions)

View changed files

📝 langserve/server.py (+16 -23)
📝 tests/unit_tests/test_server_client.py (+0 -34)

📄 Description

Eager mode is not a preferred option for langsmith APIs. We thus change the /feedback to use the regular submission of feedback flow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langserve/pull/216 **Author:** [@jakerachleff](https://github.com/jakerachleff) **Created:** 11/12/2023 **Status:** ✅ Merged **Merged:** 11/16/2023 **Merged by:** [@jakerachleff](https://github.com/jakerachleff) **Base:** `main` ← **Head:** `2023-11-12-remove-eager-mode` --- ### 📝 Commits (2) - [`e831985`](https://github.com/langchain-ai/langserve/commit/e831985cf2224161be4fb9c934da3b826a9b23c3) remove eager mode on feedback - [`51694cf`](https://github.com/langchain-ai/langserve/commit/51694cf289a70c46d48326a1d1ec76ea35e1da12) lint ### 📊 Changes **2 files changed** (+16 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `langserve/server.py` (+16 -23) 📝 `tests/unit_tests/test_server_client.py` (+0 -34) </details> ### 📄 Description Eager mode is not a preferred option for langsmith APIs. We thus change the `/feedback` to use the regular submission of feedback flow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 00:20:31 -05:00
yindo closed this issue 2026-02-16 00:20:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
enhancement
help wanted
in-progress
investigate
not langserve
playground
pull-request
Mirrored from GitHub Pull Request
 question
stale
streaming
unable-to-reproduce
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langserve#433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?