langchain-ai/langserve
1
0
Fork 0
mirror of https://github.com/langchain-ai/langserve.git synced 2026-07-01 20:14:01 -04:00
Code Issues 136 Packages Projects Releases 10 Wiki Activity

[PR #425] [MERGED] Fix: Drop non json serializable values in the config prior to sending it to the server (#425) #551

New Issue
Closed
opened 2026-02-16 01:15:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:22 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langserve/pull/425
Author: @eyurtsev
Created: 1/26/2024
Status: ✅ Merged
Merged: 1/27/2024
Merged by: @eyurtsev

Base: main ← Head: eugene/fix_serialization_of_config

📝 Commits (3)

📊 Changes

3 files changed (+140 additions, -15 deletions)

View changed files

📝 langserve/client.py (+71 -13)
➕ tests/unit_tests/test_remote_client.py (+0 -0)
📝 tests/unit_tests/test_server_client.py (+69 -2)

📄 Description

This PR drops all non json serializable values in the config prior to sending the config to the server.

This seems like the correct behavior in general, which is why it's being merged without exposing a way to control it.

Any non serializable value seem to be used only locallly by the runnable or something that wraps. Server side configurable runnables are supposed to only exposed configuration that is trivially json serializable because that's how configurable runnables were designed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langserve/pull/425 **Author:** [@eyurtsev](https://github.com/eyurtsev) **Created:** 1/26/2024 **Status:** ✅ Merged **Merged:** 1/27/2024 **Merged by:** [@eyurtsev](https://github.com/eyurtsev) **Base:** `main` ← **Head:** `eugene/fix_serialization_of_config` --- ### 📝 Commits (3) - [`e69148a`](https://github.com/langchain-ai/langserve/commit/e69148aac257512118feec017f5059c2813ac0da) x - [`beb8997`](https://github.com/langchain-ai/langserve/commit/beb8997c9bcdb1c70532039db132443915982ad8) x - [`4c9ad07`](https://github.com/langchain-ai/langserve/commit/4c9ad074495e26b70ef78f0c699dfce13b65210f) x ### 📊 Changes **3 files changed** (+140 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `langserve/client.py` (+71 -13) ➕ `tests/unit_tests/test_remote_client.py` (+0 -0) 📝 `tests/unit_tests/test_server_client.py` (+69 -2) </details> ### 📄 Description This PR drops all non json serializable values in the config prior to sending the config to the server. This seems like the correct behavior in general, which is why it's being merged without exposing a way to control it. Any non serializable value seem to be used only locallly by the runnable or something that wraps. Server side configurable runnables are supposed to only exposed configuration that is trivially json serializable because that's how configurable runnables were designed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:22 -05:00
yindo closed this issue 2026-02-16 01:15:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
enhancement
help wanted
in-progress
investigate
not langserve
playground
pull-request
Mirrored from GitHub Pull Request
 question
stale
streaming
unable-to-reproduce
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langserve#551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?