langchain-ai/langserve
1
0
Fork 0
mirror of https://github.com/langchain-ai/langserve.git synced 2026-07-21 00:55:22 -04:00
Code Issues 136 Packages Projects Releases 10 Wiki Activity

[PR #593] [MERGED] Fixes associated with feedback endpoint #622

New Issue
Closed
opened 2026-02-16 01:15:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/langserve/pull/593
Author: @eyurtsev
Created: 4/3/2024
Status: ✅ Merged
Merged: 4/3/2024
Merged by: @eyurtsev

Base: main ← Head: eugene/update_tokenfeedbcak

📝 Commits (1)

📊 Changes

3 files changed (+104 additions, -20 deletions)

View changed files

📝 langserve/api_handler.py (+32 -6)
📝 langserve/schema.py (+1 -1)
📝 tests/unit_tests/test_server_client.py (+71 -13)

📄 Description

  • Fixes langsmith client not being enabled if token feedback was specified
  • Add unit test for token feedback endpoint
  • Fix schema for token feedback to accept a str in addition to a UUID
  • Add metadata even to astream log with token feedback information

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/langserve/pull/593 **Author:** [@eyurtsev](https://github.com/eyurtsev) **Created:** 4/3/2024 **Status:** ✅ Merged **Merged:** 4/3/2024 **Merged by:** [@eyurtsev](https://github.com/eyurtsev) **Base:** `main` ← **Head:** `eugene/update_tokenfeedbcak` --- ### 📝 Commits (1) - [`efe280d`](https://github.com/langchain-ai/langserve/commit/efe280d9bfc59897275948cb28d2c3182be1aeb0) x ### 📊 Changes **3 files changed** (+104 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `langserve/api_handler.py` (+32 -6) 📝 `langserve/schema.py` (+1 -1) 📝 `tests/unit_tests/test_server_client.py` (+71 -13) </details> ### 📄 Description - Fixes langsmith client not being enabled if token feedback was specified - Add unit test for token feedback endpoint - Fix schema for token feedback to accept a str in addition to a UUID - Add metadata even to astream log with token feedback information --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:40 -05:00
yindo closed this issue 2026-02-16 01:15:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
enhancement
help wanted
in-progress
investigate
not langserve
playground
pull-request
Mirrored from GitHub Pull Request
 question
stale
streaming
unable-to-reproduce
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/langserve#622
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?