mirror of
https://github.com/langchain-ai/langsmith-java.git
synced 2026-08-24 12:22:55 -04:00
Quentin Brosse
c9f51683ce
Reviewers stamping the auto-generated `Release SDK updates` PR had no signal about how much review the diff actually needs. `smith-sdks/README.md` documents that the promotion diff is either already-reviewed custom code or code generated from an already-reviewed Stainless config, but nobody reads the README before reviewing the PR — so put the note in the PR body itself. Also hoists the twice-inlined `git log` body into a `BODY` variable shared by `gh pr create` and `gh pr edit`. Rendered at the bottom of every future release PR: --- > [!NOTE] > These changes are either auto-generated or already reviewed, so only a very light review is required: guard against a potential catastrophic generation failure by checking the diff stat for an unexpectedly large number of deleted files, and confirm any deletion traces back to a legitimate commit (e.g. an endpoint removal). > See [Releasing the SDKs](https://github.com/langchain-ai/langchainplus/tree/main/smith-sdks#releasing-the-sdks) for the full instructions. --- ### Test plan - Both edited workflows parse as YAML. - Dry-ran the body construction in bash: the `> [!NOTE]` callout starts on its own line after a blank line (command substitution strips `git log`'s trailing newlines, hence `printf '%s\n\n%s\n'`). ### Sibling PRs All three must land to cover all four SDKs: - Go: langchain-ai/langsmith-go-staging#92 - Java: langchain-ai/langsmith-java-staging#53 - Python + TypeScript: langchain-ai/langchainplus#32531 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>