[PR #2] fixes runtime configuration of model #4

Open
opened 2026-02-16 06:17:50 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/memory-agent-js/pull/2
Author: @shawnzhu
Created: 2/17/2025
Status: 🔄 Open

Base: mainHead: model-provider


📝 Commits (1)

  • 5fac1a2 fixes runtime configuration of model

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/memory_agent/utils.ts (+4 -4)

📄 Description

I was trying to use models from Bedrock but could not get it work. Then I found the parameter's name should be. modelProvider instead of provider: https://github.com/langchain-ai/langchainjs/blob/dfb54dcd0d63603221ff93b1143f2a51c803f777/langchain/src/chat_models/universal.ts#L67-L80


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/memory-agent-js/pull/2 **Author:** [@shawnzhu](https://github.com/shawnzhu) **Created:** 2/17/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `model-provider` --- ### 📝 Commits (1) - [`5fac1a2`](https://github.com/langchain-ai/memory-agent-js/commit/5fac1a207103fa6833f871905ada669d3c9815dc) fixes runtime configuration of model ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/memory_agent/utils.ts` (+4 -4) </details> ### 📄 Description I was trying to use models from Bedrock but could not get it work. Then I found the parameter's name should be. `modelProvider` instead of `provider`: https://github.com/langchain-ai/langchainjs/blob/dfb54dcd0d63603221ff93b1143f2a51c803f777/langchain/src/chat_models/universal.ts#L67-L80 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 06:17:50 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/memory-agent-js#4