[PR #185] fix(supervisor_tools): remove stray or True that forces premature END #217

New Issue

2026-02-16T07:16:18-05:00

yindo commented

2026-02-16 07:16:18 -05:00

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/open_deep_research/pull/185
Author: @malachyd
Created: 8/21/2025
Status: 🔄 Open

Base: main ← Head: fix/supervisor-tools-or-true

📝 Commits (1)

71a97a8 fix(supervisor_tools): remove stray or True that forces premature END

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/open_deep_research/deep_researcher.py (+2 -2)

📄 Description

In the supervisor_tools except block:
if is_token_limit_exceeded(e, configurable.research_model) or True: The or True made the condition unconditional, ending research on any exception. Remove or True so only token-limit errors trigger END.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/open_deep_research/pull/185 **Author:** [@malachyd](https://github.com/malachyd) **Created:** 8/21/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/supervisor-tools-or-true` --- ### 📝 Commits (1) - [`71a97a8`](https://github.com/langchain-ai/open_deep_research/commit/71a97a89c80aadb104e7cb8a67ad1627c6e847c5) fix(supervisor_tools): remove stray `or True` that forces premature END ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/open_deep_research/deep_researcher.py` (+2 -2) </details> ### 📄 Description In the supervisor_tools except block: `if is_token_limit_exceeded(e, configurable.research_model) or True:` The `or True` made the condition unconditional, ending research on any exception. Remove `or True` so only token-limit errors trigger END. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 07:16:18 -05:00

yindo referenced this issue

2026-02-16 07:16:24 -05:00

[PR #245] [CLOSED] fix: add missing format placeholders to CORRECTNESS_PROMPT #244

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: langchain-ai/open_deep_research#217

[PR #185] fix(supervisor_tools): remove stray or True that forces premature END #217

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #185] fix(supervisor_tools): remove stray `or True` that forces premature END #217