langchain-ai/open_deep_research
1
0
Fork 0
mirror of https://github.com/langchain-ai/open_deep_research.git synced 2026-07-25 21:35:34 -04:00
Code Issues 49 Packages Projects Releases Wiki Activity

[PR #246] fix(legacy): replace bare except with except Exception in utils #245

New Issue
Open
opened 2026-02-16 07:16:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 07:16:24 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/open_deep_research/pull/246
Author: @llukito
Created: 2/15/2026
Status: 🔄 Open

Base: main ← Head: fix/bare-except-legacy-utils

📝 Commits (1)

  • 5a94d27 fix(legacy): replace bare except with except Exception in utils

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/legacy/utils.py (+2 -2)

📄 Description

Description

Replaced a bare except: clause with except Exception as e: in src/legacy/utils.py.

Why this matters:
Even in legacy code, bare excepts are problematic as they catch BaseException types like KeyboardInterrupt and SystemExit. This change ensures that users can still terminate long-running processes (like Deep Research agents) via standard signals like Ctrl+C, while maintaining the existing fallback logic for standard errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/open_deep_research/pull/246 **Author:** [@llukito](https://github.com/llukito) **Created:** 2/15/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/bare-except-legacy-utils` --- ### 📝 Commits (1) - [`5a94d27`](https://github.com/langchain-ai/open_deep_research/commit/5a94d2760caebcb8d3c144793d1af32e99bad1bb) fix(legacy): replace bare except with except Exception in utils ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/legacy/utils.py` (+2 -2) </details> ### 📄 Description ### Description Replaced a bare `except:` clause with `except Exception as e:` in `src/legacy/utils.py`. **Why this matters:** Even in legacy code, bare excepts are problematic as they catch `BaseException` types like `KeyboardInterrupt` and `SystemExit`. This change ensures that users can still terminate long-running processes (like Deep Research agents) via standard signals like `Ctrl+C`, while maintaining the existing fallback logic for standard errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 07:16:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langchain-ai/open_deep_research#245
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?