[PR #20] [CLOSED] Fix linter errors in feature components #33

New Issue

2026-02-16T09:17:51-05:00

yindo commented

2026-02-16 09:17:51 -05:00

📋 Pull Request Information

Original PR: https://github.com/langchain-ai/openwork/pull/20
Author: @bwhiting2356
Created: 1/17/2026
Status: ❌ Closed

Base: lint-fix-2-ui-components ← Head: lint-fix-3-feature-components

📝 Commits (6)

af02b9d Fix linter errors in backend & main process
da31c7a Fix linter errors in feature components
9fa01bc Extract selectWorkspaceFolder to separate utility file
fa548bb Fix ModelSwitcher to derive selectedProviderId instead of setState in effect
1121a26 Revert "Fix ModelSwitcher to derive selectedProviderId instead of setState in effect"
2348796 Add TODO comments for eslint-disable directives

📊 Changes

22 files changed (+468 additions, -410 deletions)

View changed files

📝 bin/cli.js (+5 -1)
📝 src/renderer/src/components/chat/ApiKeyDialog.tsx (+13 -18)
📝 src/renderer/src/components/chat/ChatContainer.tsx (+16 -9)
📝 src/renderer/src/components/chat/ChatTodos.tsx (+2 -2)
📝 src/renderer/src/components/chat/ContextUsageIndicator.tsx (+25 -24)
📝 src/renderer/src/components/chat/MessageBubble.tsx (+32 -38)
📝 src/renderer/src/components/chat/ModelSwitcher.tsx (+34 -35)
📝 src/renderer/src/components/chat/StreamingMarkdown.tsx (+1 -3)
📝 src/renderer/src/components/chat/ToolCallRenderer.tsx (+115 -66)
📝 src/renderer/src/components/chat/WorkspacePicker.tsx (+4 -32)
📝 src/renderer/src/components/panels/FilesystemPanel.tsx (+50 -39)
📝 src/renderer/src/components/settings/SettingsDialog.tsx (+7 -11)
📝 src/renderer/src/components/sidebar/ThreadSidebar.tsx (+9 -13)
📝 src/renderer/src/components/tabs/BinaryFileViewer.tsx (+5 -4)
📝 src/renderer/src/components/tabs/CodeViewer.tsx (+51 -35)
📝 src/renderer/src/components/tabs/FileViewer.tsx (+11 -11)
📝 src/renderer/src/components/tabs/ImageViewer.tsx (+26 -31)
📝 src/renderer/src/components/tabs/MediaViewer.tsx (+7 -6)
📝 src/renderer/src/components/tabs/PDFViewer.tsx (+5 -14)
📝 src/renderer/src/components/tabs/TabBar.tsx (+22 -17)

...and 2 more files

📄 Description

Part 3/4 of linter cleanup. Fixes all lint errors in feature components.

Stack: #18 → #19 → #20 → #21

Changes

Add missing return type annotations to all components
Extract utility function to separate file
Fix prettier formatting issues
Add TODO comments for legitimate setState-in-effect warnings

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/langchain-ai/openwork/pull/20 **Author:** [@bwhiting2356](https://github.com/bwhiting2356) **Created:** 1/17/2026 **Status:** ❌ Closed **Base:** `lint-fix-2-ui-components` ← **Head:** `lint-fix-3-feature-components` --- ### 📝 Commits (6) - [`af02b9d`](https://github.com/langchain-ai/openwork/commit/af02b9dc09c5f4f0fefe607dc4e410864d2a4ab2) Fix linter errors in backend & main process - [`da31c7a`](https://github.com/langchain-ai/openwork/commit/da31c7adf6c18026f3280e0407353330fc309a44) Fix linter errors in feature components - [`9fa01bc`](https://github.com/langchain-ai/openwork/commit/9fa01bcff495459c17e6a7659de34a4479ab69b0) Extract selectWorkspaceFolder to separate utility file - [`fa548bb`](https://github.com/langchain-ai/openwork/commit/fa548bbb1e79eb960ef56176ee12802bd159fd39) Fix ModelSwitcher to derive selectedProviderId instead of setState in effect - [`1121a26`](https://github.com/langchain-ai/openwork/commit/1121a263f1dc6f6507fa0f135d0623c6651a2bd9) Revert "Fix ModelSwitcher to derive selectedProviderId instead of setState in effect" - [`2348796`](https://github.com/langchain-ai/openwork/commit/23487965df7777782ce534c748797e3892c51785) Add TODO comments for eslint-disable directives ### 📊 Changes **22 files changed** (+468 additions, -410 deletions) <details> <summary>View changed files</summary> 📝 `bin/cli.js` (+5 -1) 📝 `src/renderer/src/components/chat/ApiKeyDialog.tsx` (+13 -18) 📝 `src/renderer/src/components/chat/ChatContainer.tsx` (+16 -9) 📝 `src/renderer/src/components/chat/ChatTodos.tsx` (+2 -2) 📝 `src/renderer/src/components/chat/ContextUsageIndicator.tsx` (+25 -24) 📝 `src/renderer/src/components/chat/MessageBubble.tsx` (+32 -38) 📝 `src/renderer/src/components/chat/ModelSwitcher.tsx` (+34 -35) 📝 `src/renderer/src/components/chat/StreamingMarkdown.tsx` (+1 -3) 📝 `src/renderer/src/components/chat/ToolCallRenderer.tsx` (+115 -66) 📝 `src/renderer/src/components/chat/WorkspacePicker.tsx` (+4 -32) 📝 `src/renderer/src/components/panels/FilesystemPanel.tsx` (+50 -39) 📝 `src/renderer/src/components/settings/SettingsDialog.tsx` (+7 -11) 📝 `src/renderer/src/components/sidebar/ThreadSidebar.tsx` (+9 -13) 📝 `src/renderer/src/components/tabs/BinaryFileViewer.tsx` (+5 -4) 📝 `src/renderer/src/components/tabs/CodeViewer.tsx` (+51 -35) 📝 `src/renderer/src/components/tabs/FileViewer.tsx` (+11 -11) 📝 `src/renderer/src/components/tabs/ImageViewer.tsx` (+26 -31) 📝 `src/renderer/src/components/tabs/MediaViewer.tsx` (+7 -6) 📝 `src/renderer/src/components/tabs/PDFViewer.tsx` (+5 -14) 📝 `src/renderer/src/components/tabs/TabBar.tsx` (+22 -17) _...and 2 more files_ </details> ### 📄 Description Part 3/4 of linter cleanup. Fixes all lint errors in feature components. **Stack:** #18 → #19 → **#20** → #21 ## Changes - Add missing return type annotations to all components - Extract utility function to separate file - Fix prettier formatting issues - Add TODO comments for legitimate setState-in-effect warnings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 09:17:51 -05:00

yindo closed this issue

2026-02-16 09:17:51 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: langchain-ai/openwork#33