langgenius/dify-docs
1
0
Fork 0
mirror of https://github.com/langgenius/dify-docs.git synced 2026-07-22 12:25:45 -04:00
Code Issues 10 Packages Projects Releases Wiki Activity

[DOCS]: Github Action Update Translation PR incorrect timing of operation #283

New Issue
Closed
opened 2026-02-16 05:19:44 -05:00 by yindo · 4 comments
yindo commented 2026-02-16 05:19:44 -05:00
Owner
Copy Link
Copy Source

Originally created by @CrabSAMA on GitHub (Nov 29, 2025).

Originally assigned to: @guchenhe on GitHub.

Type of Documentation Change

Error/Typo fix

Documentation Page URL or Path

No response

Current Content

https://github.com/langgenius/dify-docs/blob/5fcc31f2e28fc17ddd632eff8a66b96016d3d1c4/.github/workflows/sync_docs_analyze.yml#L384-L397

Upload analysis artifacts is conditions permit, if not required, it will be not upload.

But Update Translation PR will be trigger when Analyze Documentation Changes completed, no matter upload or not.

Suggested Changes

I think Update Translation PR trigger time need to change. Maybe it can be called after Upload analysis artifacts?

Reason for Change

No response

Code of Conduct

  • I agree to follow Dify's documentation contribution guidelines
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.
Originally created by @CrabSAMA on GitHub (Nov 29, 2025). Originally assigned to: @guchenhe on GitHub. ### Type of Documentation Change Error/Typo fix ### Documentation Page URL or Path _No response_ ### Current Content https://github.com/langgenius/dify-docs/blob/5fcc31f2e28fc17ddd632eff8a66b96016d3d1c4/.github/workflows/sync_docs_analyze.yml#L384-L397 Upload analysis artifacts is conditions permit, if not required, it will be not upload. But `Update Translation PR` will be trigger when `Analyze Documentation Changes` completed, no matter upload or not. ### Suggested Changes I think `Update Translation PR` trigger time need to change. Maybe it can be called after `Upload analysis artifacts`? ### Reason for Change _No response_ ### Code of Conduct - [x] I agree to follow Dify's documentation [contribution guidelines](https://github.com/langgenius/dify/blob/0277a37fcad5ad86aeb239485c27fffd5cd90043/CONTRIBUTING.md) - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields.
yindo added the documentationenhancement labels 2026-02-16 05:19:44 -05:00
yindo closed this issue 2026-02-16 05:19:44 -05:00
yindo commented 2026-02-16 05:19:44 -05:00
Author
Owner
Copy Link
Copy Source

@CrabSAMA commented on GitHub (Nov 29, 2025):

Maybe we can refer this feature: https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows#calling-a-reusable-workflow

@CrabSAMA commented on GitHub (Nov 29, 2025): Maybe we can refer this feature: https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows#calling-a-reusable-workflow
yindo commented 2026-02-16 05:19:44 -05:00
Author
Owner
Copy Link
Copy Source

@guchenhe commented on GitHub (Dec 2, 2025):

hi @CrabSAMA , thanks for the suggestion. i concur that there's a bit of resource inefficiency here. the impact seems minimal though as the update workflow already handles the missing artifacts. further improvements are not be a priority at this point given we'd need to refactor the workflow structure.

@guchenhe commented on GitHub (Dec 2, 2025): hi @CrabSAMA , thanks for the suggestion. i concur that there's a bit of resource inefficiency here. the impact seems minimal though as the update workflow already handles the missing artifacts. further improvements are not be a priority at this point given we'd need to refactor the workflow structure.
yindo commented 2026-02-16 05:19:44 -05:00
Author
Owner
Copy Link
Copy Source

@CrabSAMA commented on GitHub (Dec 2, 2025):

hi @CrabSAMA , thanks for the suggestion. i concur that there's a bit of resource inefficiency here. the impact seems minimal though as the update workflow already handles the missing artifacts. further improvements are not be a priority at this point given we'd need to refactor the workflow structure.

IMO this is not an issue of resource inefficiency, now pr which not about document modify (such as update docs.json), it will trigger analyze workflow, then trigger update workflow, it will make update workflow run failed. Although workflow failure does not block PR now.

Image

That failed it's about download missing artifacts, maybe 'already handles the missing artifacts' is not effective?

@CrabSAMA commented on GitHub (Dec 2, 2025): > hi [@CrabSAMA](https://github.com/CrabSAMA) , thanks for the suggestion. i concur that there's a bit of resource inefficiency here. the impact seems minimal though as the update workflow already handles the missing artifacts. further improvements are not be a priority at this point given we'd need to refactor the workflow structure. IMO this is not an issue of resource inefficiency, now pr which not about document modify (such as update `docs.json`), it will trigger analyze workflow, then trigger update workflow, it will make update workflow run failed. Although workflow failure does not block PR now. <img width="1315" height="935" alt="Image" src="https://github.com/user-attachments/assets/521671f8-6e13-47e1-9d75-c6039a501b58" /> That failed it's about download missing artifacts, maybe 'already handles the missing artifacts' is not effective?
yindo commented 2026-02-16 05:19:44 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Dec 14, 2025):

Hi, @CrabSAMA. I'm Dosu, and I'm helping the dify-docs team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You raised a concern about the "Update Translation PR" GitHub Action triggering immediately after "Analyze Documentation Changes," even when no analysis artifacts are uploaded.
  • This causes unnecessary workflow failures, especially for PRs unrelated to documentation.
  • The maintainer acknowledged the inefficiency but noted the impact is minimal and prioritized other tasks.
  • You pointed out that the current missing artifact handling may not be fully effective, leading to failed runs.

What's Next:

  • Please let me know if this issue is still relevant with the latest version of the dify-docs repository by commenting here.
  • If I don’t hear back within 5 days, I will automatically close this issue.

Thanks for your understanding and contribution!

@dosubot[bot] commented on GitHub (Dec 14, 2025): Hi, @CrabSAMA. I'm [Dosu](https://dosu.dev), and I'm helping the dify-docs team manage their backlog and am marking this issue as stale. **Issue Summary:** - You raised a concern about the "Update Translation PR" GitHub Action triggering immediately after "Analyze Documentation Changes," even when no analysis artifacts are uploaded. - This causes unnecessary workflow failures, especially for PRs unrelated to documentation. - The maintainer acknowledged the inefficiency but noted the impact is minimal and prioritized other tasks. - You pointed out that the current missing artifact handling may not be fully effective, leading to failed runs. **What's Next:** - Please let me know if this issue is still relevant with the latest version of the dify-docs repository by commenting here. - If I don’t hear back within 5 days, I will automatically close this issue. Thanks for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
documentation
enhancement
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label documentation enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-docs#283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?