langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-21 17:45:23 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #242] [MERGED] set service_account_info as None when vertex_service_account_key param is not set #1210

New Issue
Closed
opened 2026-02-16 10:22:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 10:22:19 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/242
Author: @shohei-ihaya
Created: 2/23/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @crazywoola

Base: main ← Head: fix-vertexai-credentials

📝 Commits (2)

  • 57335ae set service_account_info as None when vertex_service_account_key param is not set
  • f4d9213 bump up version

📊 Changes

3 files changed (+29 additions, -5 deletions)

View changed files

📝 models/vertex_ai/manifest.yaml (+1 -1)
📝 models/vertex_ai/models/llm/llm.py (+14 -2)
📝 models/vertex_ai/models/text_embedding/text_embedding.py (+14 -2)

📄 Description

When I leave blank Service Account Key field to use ADC(Application Default Credential), got error "vertex_service_account_key"
image

To fix this issue, set service_account_info as None when vertex_service_account_key param is not set.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/242 **Author:** [@shohei-ihaya](https://github.com/shohei-ihaya) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix-vertexai-credentials` --- ### 📝 Commits (2) - [`57335ae`](https://github.com/langgenius/dify-official-plugins/commit/57335aef43ae8fdef82cd7834db99e9c334d4bd5) set service_account_info as None when vertex_service_account_key param is not set - [`f4d9213`](https://github.com/langgenius/dify-official-plugins/commit/f4d92134b45b21dad79bca384726a68643edaaae) bump up version ### 📊 Changes **3 files changed** (+29 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `models/vertex_ai/manifest.yaml` (+1 -1) 📝 `models/vertex_ai/models/llm/llm.py` (+14 -2) 📝 `models/vertex_ai/models/text_embedding/text_embedding.py` (+14 -2) </details> ### 📄 Description When I leave blank `Service Account Key` field to use ADC(Application Default Credential), got error "vertex_service_account_key" <img width="375" alt="image" src="https://github.com/user-attachments/assets/b51e9d95-a69d-466f-8964-305bbf8a577a" /> To fix this issue, set service_account_info as None when vertex_service_account_key param is not set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:22:19 -05:00
yindo closed this issue 2026-02-16 10:22:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1210
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?