langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-21 17:45:23 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #442] [MERGED] fix(Jina): Mark base_url as not required because handled with default in code #1368

New Issue
Closed
opened 2026-02-16 10:22:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 10:22:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/442
Author: @DavideDelbianco
Created: 3/12/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @crazywoola

Base: main ← Head: fix/jina-manifest-params

📝 Commits (1)

  • b675d32 fix(Jina): Mark base_url as not required because handled with default in code

📊 Changes

3 files changed (+5 additions, -4 deletions)

View changed files

📝 models/jina/manifest.yaml (+1 -1)
📝 models/jina/models/rerank/rerank.py (+3 -1)
📝 models/jina/provider/jina.yaml (+1 -2)

📄 Description

Adding the model in load balancing mode would fail because the base_url is not specified in provider form_manifest, but required by model form_manifest
The url is handled with a default value both in text_embedding.py and rerank.py

Closes #441

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/442 **Author:** [@DavideDelbianco](https://github.com/DavideDelbianco) **Created:** 3/12/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix/jina-manifest-params` --- ### 📝 Commits (1) - [`b675d32`](https://github.com/langgenius/dify-official-plugins/commit/b675d32aecac2ba3f53b1266cc0dbcd8557cc57e) fix(Jina): Mark base_url as not required because handled with default in code ### 📊 Changes **3 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `models/jina/manifest.yaml` (+1 -1) 📝 `models/jina/models/rerank/rerank.py` (+3 -1) 📝 `models/jina/provider/jina.yaml` (+1 -2) </details> ### 📄 Description Adding the model in load balancing mode would fail because the base_url is not specified in provider form_manifest, but required by model form_manifest The url is handled with a default value both in `text_embedding.py` and `rerank.py` Closes #441 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:22:45 -05:00
yindo closed this issue 2026-02-16 10:22:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1368
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?