langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-22 01:55:27 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #527] [MERGED] fix: improve error handling in GitHub README tool #1423

New Issue
Closed
opened 2026-02-16 10:22:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 10:22:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/527
Author: @itning
Created: 3/20/2025
Status: ✅ Merged
Merged: 3/21/2025
Merged by: @crazywoola

Base: main ← Head: fix_github_repository_readme

📝 Commits (1)

  • c47cf18 fix: improve error handling in GitHub README tool

📊 Changes

2 files changed (+11 additions, -16 deletions)

View changed files

📝 tools/github/manifest.yaml (+1 -1)
📝 tools/github/tools/github_repository_readme.py (+10 -15)

📄 Description

Why modify the error handling logic of this tool?

When retrying on failure is enabled, the retry will not be executed because the system does not capture the error.

image

image

After modification, retry is allowed.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/527 **Author:** [@itning](https://github.com/itning) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix_github_repository_readme` --- ### 📝 Commits (1) - [`c47cf18`](https://github.com/langgenius/dify-official-plugins/commit/c47cf181d927617d61a7dda17f5304cccf9fdf74) fix: improve error handling in GitHub README tool ### 📊 Changes **2 files changed** (+11 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `tools/github/manifest.yaml` (+1 -1) 📝 `tools/github/tools/github_repository_readme.py` (+10 -15) </details> ### 📄 Description Why modify the error handling logic of this tool? When retrying on failure is enabled, the retry will not be executed because the system does not capture the error. ![image](https://github.com/user-attachments/assets/6240ca52-39cd-4aa6-b0cc-f725946916d9) ![image](https://github.com/user-attachments/assets/ccdce029-f089-4b28-8609-d6a4e4048c43) After modification, retry is allowed. ![image](https://github.com/user-attachments/assets/df7c465f-a7b4-43b7-a8a4-061c84376459) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:22:54 -05:00
yindo closed this issue 2026-02-16 10:22:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?