[PR #663] [MERGED] fix: model-ollama add more friendly exception msg when HTTPError #1482

Closed
opened 2026-02-16 10:23:04 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/663
Author: @StrayDragon
Created: 4/6/2025
Status: Merged
Merged: 4/10/2025
Merged by: @Yeuoly

Base: mainHead: l8ng/provider-ollama-friendly-tip


📝 Commits (2)

  • c1741c8 fix: model-ollama add more friendly exception msg when HTTPError
  • e0272c3 bump: models-ollama version

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 models/ollama/manifest.yaml (+1 -1)
📝 models/ollama/models/text_embedding/text_embedding.py (+4 -0)

📄 Description

Related Issue or Context

for debugging easily on dify logs and minimize misunderstandings

ref: https://github.com/langgenius/dify-official-plugins/issues/1214

Type of Change

  • Bug Fix (non-breaking change which fixes an Issue)
  • New Feature (non-breaking change which adds Functionality)
  • Breaking Change (fix or feature that may cause existing Functionality to not work as expected)
  • Documentation Update
  • Code Refactoring
  • Other

Version Control (if applicable)

  • Version bumped in Manifest.yaml (top-level Version field, not in Meta section)

Test Evidence (if applicable)

Important

Visual Proof is required for Bug Fixes, New Features, and Breaking Changes:

Screenshots or Video/GIF:

reproduce:

try add embedding model '' shaw/dmeta-embedding-zh to models provider ollama

  • before:
    图片

  • after:
    图片

TODO: maybe need change style on dify/web or limit output length ...

but more details than before, and reduce misunderstandings about the main library to a certain extent.

Note

For Non-LLM Models Changes:

  • Bug Fixes:
    • Show the Fix working
  • New Features:
    • Demonstrate the Functionality
  • Breaking Changes:
    • Show both Old and New Behavior

For LLM Models Changes:

  • Bug Fixes:
    • Show the Fix working with Example Inputs/Outputs
  • New Features:
    • Demonstrate the Functionality with Example Inputs/Outputs
  • Breaking Changes (requires comprehensive Testing):
    • Conversation & Interaction:
      • Message Flow Handling (System Messages and User→Assistant Turn-taking)
      • Tool Interaction Flow (Multi-round Usage and Output Handling if applicable)
    • Input/Output Handling:
      • Multimodal Input Handling (Images, PDFs, Audio, Video if applicable)
      • Multimodal Output Generation (Images, Audio, Video if applicable)
      • Structured Output Format (if applicable)
    • Metrics:
      • Token Consumption Metrics
    • Others:
      • e.g., Reasoning Process for Claude 3.7 Sonnet, Grounding for Gemini (if applicable)

Environment Verification

Important

At least one environment must be tested.

Local Deployment Environment

Local Deployment Dify Version:

  • Changes tested in a Clean Environment that matches Production Configuration

SaaS Environment

  • Testing performed on cloud.dify.ai
  • Changes tested in a Clean Environment that matches Production Configuration

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/663 **Author:** [@StrayDragon](https://github.com/StrayDragon) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `l8ng/provider-ollama-friendly-tip` --- ### 📝 Commits (2) - [`c1741c8`](https://github.com/langgenius/dify-official-plugins/commit/c1741c8a1fcc0ae9a53097a593312e6a1423b4a0) fix: model-ollama add more friendly exception msg when HTTPError - [`e0272c3`](https://github.com/langgenius/dify-official-plugins/commit/e0272c384c1f86f12d676150489289de19700a35) bump: models-ollama version ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `models/ollama/manifest.yaml` (+1 -1) 📝 `models/ollama/models/text_embedding/text_embedding.py` (+4 -0) </details> ### 📄 Description ## Related Issue or Context <!-- - Link related Issues if applicable: #issue_number - Or provide Context about why this Change is needed --> for debugging easily on dify logs and minimize misunderstandings ref: https://github.com/langgenius/dify-official-plugins/issues/1214 ## Type of Change <!-- Put an `x` in all the boxes that apply --> - [ ] Bug Fix (non-breaking change which fixes an Issue) - [ ] New Feature (non-breaking change which adds Functionality) - [ ] Breaking Change (fix or feature that may cause existing Functionality to not work as expected) - [x] Documentation Update - [ ] Code Refactoring - [ ] Other ## Version Control (if applicable) - [x] Version bumped in Manifest.yaml (top-level `Version` field, not in Meta section) <!-- Version format: MAJOR.MINOR.PATCH - MAJOR (0.x.x): Reserved for Major Releases with widespread Breaking Changes - MINOR (x.0.x): For New Features or limited Breaking Changes - PATCH (x.x.0): For backwards-compatible Bug Fixes and minor Improvements - Note: Each version component (MAJOR, MINOR, PATCH) can be 2 digits, e.g., 10.11.22 --> ## Test Evidence (if applicable) > [!IMPORTANT] > Visual Proof is required for Bug Fixes, New Features, and Breaking Changes: ### Screenshots or Video/GIF: <!-- Provide your evidence here --> reproduce: try add embedding model '' shaw/dmeta-embedding-zh to models provider ollama - before: ![图片](https://github.com/user-attachments/assets/2430e569-8e69-4d38-a5d1-8e308c7aa41e) - after: ![图片](https://github.com/user-attachments/assets/6d3dcef3-08e5-4ebd-91e7-69ea36212a8d) TODO: maybe need change style on dify/web or limit output length ... but more details than before, and reduce misunderstandings about the main library to a certain extent. > [!NOTE] > For Non-LLM Models Changes: > - **Bug Fixes**: > - [ ] Show the Fix working > - **New Features**: > - [ ] Demonstrate the Functionality > - **Breaking Changes**: > - [ ] Show both Old and New Behavior > > For LLM Models Changes: > - **Bug Fixes**: > - [ ] Show the Fix working with Example Inputs/Outputs > - **New Features**: > - [ ] Demonstrate the Functionality with Example Inputs/Outputs > - **Breaking Changes** (requires comprehensive Testing): > - **Conversation & Interaction**: > - [ ] Message Flow Handling (System Messages and User→Assistant Turn-taking) > - [ ] Tool Interaction Flow (Multi-round Usage and Output Handling if applicable) > - **Input/Output Handling**: > - [ ] Multimodal Input Handling (Images, PDFs, Audio, Video if applicable) > - [ ] Multimodal Output Generation (Images, Audio, Video if applicable) > - [ ] Structured Output Format (if applicable) > - **Metrics**: > - [ ] Token Consumption Metrics > - **Others**: > - [ ] e.g., Reasoning Process for Claude 3.7 Sonnet, Grounding for Gemini (if applicable) <!-- LLM Models Test Example: --> <!-- https://github.com/langgenius/dify-official-plugins/blob/main/.assets/test-examples/llm-plugin-tests/llm_test_example.md --> ### Environment Verification > [!IMPORTANT] > At least one environment must be tested. #### Local Deployment Environment Local Deployment Dify Version: <!-- Specify your version (e.g., 1.1.3) --> - [x] Changes tested in a Clean Environment that matches Production Configuration <!-- - Python virtual env matching Manifest.yaml & requirements.txt - No breaking changes in Dify that may affect the testing result --> #### SaaS Environment - [ ] Testing performed on cloud.dify.ai - [ ] Changes tested in a Clean Environment that matches Production Configuration <!-- - Python virtual env matching Manifest.yaml & requirements.txt --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:23:04 -05:00
yindo closed this issue 2026-02-16 10:23:04 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1482