langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-23 10:35:29 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #1131] [MERGED] Fix tool response handling bugs in Dify Agent Strategies #1728

New Issue
Closed
opened 2026-02-16 10:23:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 10:23:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/1131
Author: @GonzaHM
Created: 6/19/2025
Status: ✅ Merged
Merged: 6/19/2025
Merged by: @crazywoola

Base: main ← Head: fix/dify-agent-strategies-response-bug

📝 Commits (3)

  • 80448f8 fix: Correct variable reference in function_calling.py
  • 134d96b fix: Correct constructor parameter order in ReActAgentStrategy
  • 1a26af0 chore: Update version from 0.0.16 to 0.0.17

📊 Changes

3 files changed (+10 additions, -10 deletions)

View changed files

📝 agent-strategies/cot_agent/manifest.yaml (+1 -1)
📝 agent-strategies/cot_agent/strategies/ReAct.py (+2 -2)
📝 agent-strategies/cot_agent/strategies/function_calling.py (+7 -7)

📄 Description

Related Issues or Context

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I'm Using dify_plugin>=0.3.0,<0.4.0 in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: 1.3.1 , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

Function Calling

before after
screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-17_17_31 screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-18_11_36

ReAct

before after
screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-18_09_29 screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-18_10_41

※ Workflow created for testing purposes ↓
screencapture-dify2-coreprice-app-9a42d64a-5f3a-4dc1-9a70-80de6d7bf458-workflow-2025-06-19-17_16_57

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/1131 **Author:** [@GonzaHM](https://github.com/GonzaHM) **Created:** 6/19/2025 **Status:** ✅ Merged **Merged:** 6/19/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix/dify-agent-strategies-response-bug` --- ### 📝 Commits (3) - [`80448f8`](https://github.com/langgenius/dify-official-plugins/commit/80448f8dca2592f1ccd9b6493ce6ddbc17b0d311) fix: Correct variable reference in function_calling.py - [`134d96b`](https://github.com/langgenius/dify-official-plugins/commit/134d96be52215fa21e88d429cc5da4d007cd1a6e) fix: Correct constructor parameter order in ReActAgentStrategy - [`1a26af0`](https://github.com/langgenius/dify-official-plugins/commit/1a26af0c8ddae481b96585ba9e88616a484e40d6) chore: Update version from 0.0.16 to 0.0.17 ### 📊 Changes **3 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `agent-strategies/cot_agent/manifest.yaml` (+1 -1) 📝 `agent-strategies/cot_agent/strategies/ReAct.py` (+2 -2) 📝 `agent-strategies/cot_agent/strategies/function_calling.py` (+7 -7) </details> ### 📄 Description ## Related Issues or Context <!-- ⚠️ NOTE: This repository is for Dify Official Plugins only. For community contributions, please submit to https://github.com/langgenius/dify-plugins instead. - Link Related Issues if Applicable: #issue_number - Or Provide Context about Why this Change is Needed --> ## This PR contains Changes to *Non-Plugin* <!-- Put an `x` in all the boxes that apply by replacing [ ] with [x] For example: - [x] Documentation --> - [ ] Documentation - [ ] Other ## This PR contains Changes to *Non-LLM Models Plugin* - [ ] I have Run Comprehensive Tests Relevant to My Changes <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## This PR contains Changes to *LLM Models Plugin* <!-- LLM Models Test Example: --> <!-- https://github.com/langgenius/dify-official-plugins/blob/main/.assets/test-examples/llm-plugin-tests/llm_test_example.md --> - [ ] My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Structured Output Format (JSON, XML, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Token Consumption Metrics <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] Other Changes (Add New Models, Fix Model Parameters etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## Version Control (Any Changes to the Plugin Will Require Bumping the Version) - [x] I have Bumped Up the Version in Manifest.yaml (Top-Level `Version` Field, Not in Meta Section) <!-- ⚠️ NOTE: Version Format: MAJOR.MINOR.PATCH - MAJOR (0.x.x): Reserved for Significant architectural changes or incompatible API modifications - MINOR (x.0.x): For New feature additions while maintaining backward compatibility - PATCH (x.x.0): For Backward-compatible bug fixes and minor improvements - Note: Each Version Component (MAJOR, MINOR, PATCH) Can Be 2 Digits, e.g., 10.11.22 --> ## Dify Plugin SDK Version - [x] I'm Using `dify_plugin>=0.3.0,<0.4.0` in requirements.txt ([SDK docs](https://github.com/langgenius/dify-plugin-sdks/blob/main/python/README.md)) ## Environment Verification (If Any Code Changes) <!-- ⚠️ NOTE: At Least One Environment Must Be Tested. --> ### Local Deployment Environment - [x] Dify Version is: 1.3.1 <!-- Specify Your Version (e.g., 1.2.0) -->, I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration. <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt - No Breaking Changes in Dify That May Affect the Testing Result --> Function Calling | before | after | |--------|-------| | ![screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-17_17_31](https://github.com/user-attachments/assets/bada4a54-c2f6-4041-9f16-e06590942052) | ![screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-18_11_36](https://github.com/user-attachments/assets/8ab15300-70bd-4718-9c43-d729bf737e30) | ReAct | before | after | |--------|-------| | ![screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-18_09_29](https://github.com/user-attachments/assets/4f4b5a0d-81f4-404a-ab4b-9cb05729cd8d) | ![screencapture-dify2-coreprice-app-a2c4ebd0-14a0-424e-a755-95aaed172513-workflow-2025-06-19-18_10_41](https://github.com/user-attachments/assets/686e176a-467c-471c-8fd6-a69558bb55f6) | ※ Workflow created for testing purposes ↓ ![screencapture-dify2-coreprice-app-9a42d64a-5f3a-4dc1-9a70-80de6d7bf458-workflow-2025-06-19-17_16_57](https://github.com/user-attachments/assets/04587fbc-15f6-4d0e-a486-6dbd8b505267) ### SaaS Environment - [ ] I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:23:48 -05:00
yindo closed this issue 2026-02-16 10:23:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1728
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?