langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-21 17:45:23 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #1410] [MERGED] fix: Gitlab Plugin - Incorrect arg passsed to get_project_id in files tool #1874

New Issue
Closed
opened 2026-02-16 10:24:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 10:24:15 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/1410
Author: @austinbcdev
Created: 8/4/2025
Status: ✅ Merged
Merged: 8/8/2025
Merged by: @crazywoola

Base: main ← Head: bugfix/gitlabplugin-incorrect-arg

📝 Commits (2)

  • 4b4e04e fix incorrect arg passsed to get project id in gitlab file tool invocation
  • 3b1d8ff bump plugin version

📊 Changes

2 files changed (+5 additions, -4 deletions)

View changed files

📝 tools/gitlab/manifest.yaml (+1 -1)
📝 tools/gitlab/tools/gitlab_files.py (+4 -3)

📄 Description

An incorrect variable was passed to the helper method get_project_id on line 34 in ./tools/gitlab/tools/gitlab_files.py.

Two paths are taken:

  1. If repository is a non-empty string, then retrieve the Gitlab file via request using repository name.
  2. If 'repository' is an empty string, then retrieve the Gitlab file using the Gitlab Projects API using project name.

Path 2) incorrectly passed the repository variable as an argument to the get_project_id helper method.

This PR simply swaps the incorrect argument repository to the project variable defined in the GitlabFilesTool _invoke method.

Related Issues or Context

Related Issue

fix https://github.com/langgenius/dify-official-plugins/issues/1401

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)
    • Patch - bumped from 0.0.4 ==> 0.0.5

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.5.0 is in requirements.txt (SDK docs)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/1410 **Author:** [@austinbcdev](https://github.com/austinbcdev) **Created:** 8/4/2025 **Status:** ✅ Merged **Merged:** 8/8/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `bugfix/gitlabplugin-incorrect-arg` --- ### 📝 Commits (2) - [`4b4e04e`](https://github.com/langgenius/dify-official-plugins/commit/4b4e04e4480232d61d5f5036ce9538bcde5369ee) fix incorrect arg passsed to get project id in gitlab file tool invocation - [`3b1d8ff`](https://github.com/langgenius/dify-official-plugins/commit/3b1d8ff32a815aea7c867b92255026463ae99a8c) bump plugin version ### 📊 Changes **2 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tools/gitlab/manifest.yaml` (+1 -1) 📝 `tools/gitlab/tools/gitlab_files.py` (+4 -3) </details> ### 📄 Description An incorrect variable was passed to the helper method `get_project_id` on line 34 in `./tools/gitlab/tools/gitlab_files.py`. Two paths are taken: 1) If `repository` is a non-empty string, then retrieve the Gitlab file via request using repository name. 2) If 'repository' is an empty string, then retrieve the Gitlab file using the Gitlab Projects API using project name. Path 2) incorrectly passed the `repository` variable as an argument to the `get_project_id` helper method. This PR simply swaps the incorrect argument `repository` to the `project` variable defined in the `GitlabFilesTool` `_invoke` method. ## Related Issues or Context [Related Issue](https://github.com/langgenius/dify-official-plugins/issues/1401) fix https://github.com/langgenius/dify-official-plugins/issues/1401 ## Version Control (Any Changes to the Plugin Will Require Bumping the Version) - [X] I have Bumped Up the Version in Manifest.yaml (Top-Level `Version` Field, Not in Meta Section) - Patch - bumped from 0.0.4 ==> 0.0.5 ## Dify Plugin SDK Version - [X] I have Ensured `dify_plugin>=0.3.0,<0.5.0` is in requirements.txt ([SDK docs](https://github.com/langgenius/dify-plugin-sdks/blob/main/python/README.md)) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:24:15 -05:00
yindo closed this issue 2026-02-16 10:24:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?