[PR #1446] [MERGED] Fix(openai): tool use issue with latest openai SDK, gpt 5 chat latest might contains incorrect context window size #1893

Closed
opened 2026-02-16 10:24:19 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/1446
Author: @fdb02983rhy
Created: 8/7/2025
Status: Merged
Merged: 8/7/2025
Merged by: @crazywoola

Base: mainHead: fix(openai)-gpt-5-chat-may-contains-incorrect-context-window


📝 Commits (6)

  • 007c276 Update context size and max_tokens for GPT-5 chat
  • b23db92 Bump OpenAI plugin version to 0.2.2
  • c73fd3e Update gpt-5-chat-latest.yaml
  • 57f4323 Replace isinstance checks with duck-typing in LLM
  • 17ec18d Update llm.py
  • 9ad502d Update llm.py

📊 Changes

3 files changed (+9 additions, -10 deletions)

View changed files

📝 models/openai/manifest.yaml (+1 -1)
📝 models/openai/models/llm/gpt-5-chat-latest.yaml (+5 -2)
📝 models/openai/models/llm/llm.py (+3 -7)

📄 Description

Related Issues or Context

Adjusted context_size and max_tokens in gpt-5-chat-latest.yaml based on API testing and documentation. Added comments to clarify discrepancies between documentation and actual API limits.

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
    CleanShot 2025-08-08 at 06 02 04@2x

  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)

  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)
    CleanShot 2025-08-08 at 05 11 04@2x

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.5.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/1446 **Author:** [@fdb02983rhy](https://github.com/fdb02983rhy) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/7/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix(openai)-gpt-5-chat-may-contains-incorrect-context-window` --- ### 📝 Commits (6) - [`007c276`](https://github.com/langgenius/dify-official-plugins/commit/007c2762fd0b62b1632598a8eeb1dafd45b6b873) Update context size and max_tokens for GPT-5 chat - [`b23db92`](https://github.com/langgenius/dify-official-plugins/commit/b23db92a6d4dda17843408585bf869ae8b84f22e) Bump OpenAI plugin version to 0.2.2 - [`c73fd3e`](https://github.com/langgenius/dify-official-plugins/commit/c73fd3ed02d3ea74874a34dd714cd909e4202d9b) Update gpt-5-chat-latest.yaml - [`57f4323`](https://github.com/langgenius/dify-official-plugins/commit/57f4323a4b51445cdba47c75c6f3cbf3d0df4ebc) Replace isinstance checks with duck-typing in LLM - [`17ec18d`](https://github.com/langgenius/dify-official-plugins/commit/17ec18d7b989adb95710d6f329c3c4684688c290) Update llm.py - [`9ad502d`](https://github.com/langgenius/dify-official-plugins/commit/9ad502de045738066ed3a6b513c0e63a49360e8f) Update llm.py ### 📊 Changes **3 files changed** (+9 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `models/openai/manifest.yaml` (+1 -1) 📝 `models/openai/models/llm/gpt-5-chat-latest.yaml` (+5 -2) 📝 `models/openai/models/llm/llm.py` (+3 -7) </details> ### 📄 Description ## Related Issues or Context Adjusted context_size and max_tokens in gpt-5-chat-latest.yaml based on API testing and documentation. Added comments to clarify discrepancies between documentation and actual API limits. ## This PR contains Changes to *Non-Plugin* <!-- Put an `x` in all the boxes that apply by replacing [ ] with [x] For example: - [x] Documentation --> - [ ] Documentation - [ ] Other ## This PR contains Changes to *Non-LLM Models Plugin* - [ ] I have Run Comprehensive Tests Relevant to My Changes <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## This PR contains Changes to *LLM Models Plugin* <!-- LLM Models Test Example: --> <!-- https://github.com/langgenius/dify-official-plugins/blob/main/.assets/test-examples/llm-plugin-tests/llm_test_example.md --> - [ ] My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [x] My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node) <img width="1492" height="1250" alt="CleanShot 2025-08-08 at 06 02 04@2x" src="https://github.com/user-attachments/assets/4e73f5d0-65f0-4d85-83ec-991a3f56f9f0" /> - [ ] My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Structured Output Format (JSON, XML, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Token Consumption Metrics <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [x] Other Changes (Add New Models, Fix Model Parameters etc.) <img width="2034" height="890" alt="CleanShot 2025-08-08 at 05 11 04@2x" src="https://github.com/user-attachments/assets/a9d7ea3e-94c3-4c78-aca4-3fa41a62e047" /> ## Version Control (Any Changes to the Plugin Will Require Bumping the Version) - [x] I have Bumped Up the Version in Manifest.yaml (Top-Level `Version` Field, Not in Meta Section) <!-- ⚠️ NOTE: Version Format: MAJOR.MINOR.PATCH - MAJOR (0.x.x): Reserved for Significant architectural changes or incompatible API modifications - MINOR (x.0.x): For New feature additions while maintaining backward compatibility - PATCH (x.x.0): For Backward-compatible bug fixes and minor improvements - Note: Each Version Component (MAJOR, MINOR, PATCH) Can Be 2 Digits, e.g., 10.11.22 --> ## Dify Plugin SDK Version - [x] I have Ensured `dify_plugin>=0.3.0,<0.5.0` is in requirements.txt ([SDK docs](https://github.com/langgenius/dify-plugin-sdks/blob/main/python/README.md)) ## Environment Verification (If Any Code Changes) <!-- ⚠️ NOTE: At Least One Environment Must Be Tested. --> ### Local Deployment Environment - [ ] Dify Version is: <!-- Specify Your Version (e.g., 1.2.0) -->, I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration. <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt - No Breaking Changes in Dify That May Affect the Testing Result --> ### SaaS Environment - [x] I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:24:19 -05:00
yindo closed this issue 2026-02-16 10:24:19 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#1893