langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-21 17:45:23 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #2076] [MERGED] Fix: Tongyi Qianwen model temporary file leak issue. #2243

New Issue
Closed
opened 2026-02-16 11:16:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 11:16:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/2076
Author: @WzzP
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/20/2025
Merged by: @crazywoola

Base: main ← Head: fix/tongyi-temp-file-cleanup

📝 Commits (6)

  • 4994f28 修复: 通义千问模型临时文件泄漏问题
  • 380c0c4 Update models/tongyi/models/llm/llm.py
  • fbb5267 改进: 添加日志记录和清理列表
  • 26d547f add：更新版本号
  • f3953b5 fix
  • 130c8ad Merge branch 'main' into fix/tongyi-temp-file-cleanup

📊 Changes

2 files changed (+144 additions, -109 deletions)

View changed files

📝 models/tongyi/manifest.yaml (+1 -1)
📝 models/tongyi/models/llm/llm.py (+143 -108)

📄 Description

  • 添加临时文件追踪机制，在类初始化时创建 _temp_files 列表
  • 在 _save_base64_to_file 方法中记录创建的临时文件
  • 添加 _cleanup_temp_files 方法用于清理临时文件
  • 在 _handle_generate_response 和 _handle_generate_stream_response 中使用 try-finally 确保临时文件被清理
  • 修复 _upload_file_to_tongyi 方法中的临时文件泄漏问题

这个修复解决了处理 base64 编码的图片/视频和文档上传时临时文件累积的问题，避免长期运行服务时磁盘空间被占用。

Related Issues or Context

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.6.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/2076 **Author:** [@WzzP](https://github.com/WzzP) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/20/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix/tongyi-temp-file-cleanup` --- ### 📝 Commits (6) - [`4994f28`](https://github.com/langgenius/dify-official-plugins/commit/4994f28311ef894341c135b5a305692e4e88ef5d) 修复: 通义千问模型临时文件泄漏问题 - [`380c0c4`](https://github.com/langgenius/dify-official-plugins/commit/380c0c4a0b9eaae101cba3c8fa3c789284685a44) Update models/tongyi/models/llm/llm.py - [`fbb5267`](https://github.com/langgenius/dify-official-plugins/commit/fbb5267f850b028d2e492306c0b0b989d6ad25de) 改进: 添加日志记录和清理列表 - [`26d547f`](https://github.com/langgenius/dify-official-plugins/commit/26d547feeb97556feed8fbb5d411e114d2d91a15) add：更新版本号 - [`f3953b5`](https://github.com/langgenius/dify-official-plugins/commit/f3953b53225059754c85bf2961b6e65bd8497fce) fix - [`130c8ad`](https://github.com/langgenius/dify-official-plugins/commit/130c8ad828f2fcf76587e563517be60e0e039824) Merge branch 'main' into fix/tongyi-temp-file-cleanup ### 📊 Changes **2 files changed** (+144 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `models/tongyi/manifest.yaml` (+1 -1) 📝 `models/tongyi/models/llm/llm.py` (+143 -108) </details> ### 📄 Description - 添加临时文件追踪机制，在类初始化时创建 _temp_files 列表 - 在 _save_base64_to_file 方法中记录创建的临时文件 - 添加 _cleanup_temp_files 方法用于清理临时文件 - 在 _handle_generate_response 和 _handle_generate_stream_response 中使用 try-finally 确保临时文件被清理 - 修复 _upload_file_to_tongyi 方法中的临时文件泄漏问题 这个修复解决了处理 base64 编码的图片/视频和文档上传时临时文件累积的问题，避免长期运行服务时磁盘空间被占用。 ## Related Issues or Context <!-- ⚠️ NOTE: This repository is for Dify Official Plugins only. For community contributions, please submit to https://github.com/langgenius/dify-plugins instead. - Link Related Issues if Applicable: #issue_number - Or Provide Context about Why this Change is Needed --> ## This PR contains Changes to *Non-Plugin* <!-- Put an `x` in all the boxes that apply by replacing [ ] with [x] For example: - [x] Documentation --> - [ ] Documentation - [ ] Other ## This PR contains Changes to *Non-LLM Models Plugin* - [ ] I have Run Comprehensive Tests Relevant to My Changes <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## This PR contains Changes to *LLM Models Plugin* <!-- LLM Models Test Example: --> <!-- https://github.com/langgenius/dify-official-plugins/blob/main/.assets/test-examples/llm-plugin-tests/llm_test_example.md --> - [ ] My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Structured Output Format (JSON, XML, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Token Consumption Metrics <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] Other Changes (Add New Models, Fix Model Parameters etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## Version Control (Any Changes to the Plugin Will Require Bumping the Version) - [ ] I have Bumped Up the Version in Manifest.yaml (Top-Level `Version` Field, Not in Meta Section) <!-- ⚠️ NOTE: Version Format: MAJOR.MINOR.PATCH - MAJOR (0.x.x): Reserved for Significant architectural changes or incompatible API modifications - MINOR (x.0.x): For New feature additions while maintaining backward compatibility - PATCH (x.x.0): For Backward-compatible bug fixes and minor improvements - Note: Each Version Component (MAJOR, MINOR, PATCH) Can Be 2 Digits, e.g., 10.11.22 --> ## Dify Plugin SDK Version - [ ] I have Ensured `dify_plugin>=0.3.0,<0.6.0` is in requirements.txt ([SDK docs](https://github.com/langgenius/dify-plugin-sdks/blob/main/python/README.md)) ## Environment Verification (If Any Code Changes) <!-- ⚠️ NOTE: At Least One Environment Must Be Tested. --> ### Local Deployment Environment - [ ] Dify Version is: <!-- Specify Your Version (e.g., 1.2.0) -->, I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration. <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt - No Breaking Changes in Dify That May Affect the Testing Result --> ### SaaS Environment - [ ] I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 11:16:27 -05:00
yindo closed this issue 2026-02-16 11:16:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#2243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?