langgenius/dify-official-plugins
1
0
Fork 0
mirror of https://github.com/langgenius/dify-official-plugins.git synced 2026-07-21 17:45:23 -04:00
Code Issues 54 Packages Projects Releases Wiki Activity

[PR #2117] [MERGED] fix it ignores the 'thinking' field in streamed responses from the ollama #2271

New Issue
Closed
opened 2026-02-16 11:16:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 11:16:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-official-plugins/pull/2117
Author: @zhangyy130
Created: 11/21/2025
Status: ✅ Merged
Merged: 11/24/2025
Merged by: @crazywoola

Base: main ← Head: fix_ollama_ignores_thinking

📝 Commits (8)

📊 Changes

2 files changed (+32 additions, -23 deletions)

View changed files

📝 models/ollama/manifest.yaml (+1 -1)
📝 models/ollama/models/llm/llm.py (+31 -22)

📄 Description

ollama plugin ignores the 'thinking' field in streamed responses from the Ollama API and only forwards the 'content' field to Dify
Refer to the parent class "dify_plugin.interfaces.model.large_language_model.LargeLanguageModel" to implement the function _wrap_thinking_by_reasoning_content.

Related Issues or Context

  • Link Related Issues if Applicable: #2112

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

27e0a763e92898aaa8edd8c734253167
  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.6.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-official-plugins/pull/2117 **Author:** [@zhangyy130](https://github.com/zhangyy130) **Created:** 11/21/2025 **Status:** ✅ Merged **Merged:** 11/24/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix_ollama_ignores_thinking` --- ### 📝 Commits (8) - [`bf83a6e`](https://github.com/langgenius/dify-official-plugins/commit/bf83a6e2fd5aab44bc94ddb280b28b6a67c6ffdc) fix it ignores the 'thinking' field in streamed responses from the Ollama API and only forwards the 'content' field to Dify - [`25a1fd6`](https://github.com/langgenius/dify-official-plugins/commit/25a1fd61eded664baf27e0a0daedbdb213b19314) fix - [`fb1fb97`](https://github.com/langgenius/dify-official-plugins/commit/fb1fb977b4381f74c52be107d5334a85075fb253) fix - [`726d203`](https://github.com/langgenius/dify-official-plugins/commit/726d203cfd7a4a41410f69b34e6a15468bc8272c) Merge branch 'main' into fix_ollama_ignores_thinking - [`d1bbb05`](https://github.com/langgenius/dify-official-plugins/commit/d1bbb059bd6a1dae10253cc5b99a8f376bd43f03) Merge branch 'main' of https://github.com/zhangyy130/dify-official-plugins into fix_ollama_ignores_thinking - [`b646d2b`](https://github.com/langgenius/dify-official-plugins/commit/b646d2beb4d61fb5d993f7b2b92b511fd1908963) fix - [`e2d8237`](https://github.com/langgenius/dify-official-plugins/commit/e2d82374f2f1a277cf186e145b6905bf729c167c) Merge remote-tracking branch 'origin/fix_ollama_ignores_thinking' into fix_ollama_ignores_thinking - [`1320c1d`](https://github.com/langgenius/dify-official-plugins/commit/1320c1dd2c5a87137f14d9f0b511477aac939c67) fix ### 📊 Changes **2 files changed** (+32 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `models/ollama/manifest.yaml` (+1 -1) 📝 `models/ollama/models/llm/llm.py` (+31 -22) </details> ### 📄 Description ollama plugin ignores the 'thinking' field in streamed responses from the Ollama API and only forwards the 'content' field to Dify Refer to the parent class "dify_plugin.interfaces.model.large_language_model.LargeLanguageModel" to implement the function _wrap_thinking_by_reasoning_content. ## Related Issues or Context <!-- ⚠️ NOTE: This repository is for Dify Official Plugins only. For community contributions, please submit to fix https://github.com/langgenius/dify-plugins instead. - Link Related Issues if Applicable: #issue_number - Or Provide Context about Why this Change is Needed --> - Link Related Issues if Applicable: #2112 ## This PR contains Changes to *Non-Plugin* <!-- Put an `x` in all the boxes that apply by replacing [ ] with [x] For example: - [x] Documentation --> - [ ] Documentation - [ ] Other ## This PR contains Changes to *Non-LLM Models Plugin* - [ ] I have Run Comprehensive Tests Relevant to My Changes <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## This PR contains Changes to *LLM Models Plugin* <!-- LLM Models Test Example: --> <!-- https://github.com/langgenius/dify-official-plugins/blob/main/.assets/test-examples/llm-plugin-tests/llm_test_example.md --> <img width="1920" height="929" alt="27e0a763e92898aaa8edd8c734253167" src="https://github.com/user-attachments/assets/7a08369c-7ae5-4717-889f-26df4c9c68be" /> - [ ] My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Structured Output Format (JSON, XML, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Token Consumption Metrics <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> - [ ] Other Changes (Add New Models, Fix Model Parameters etc.) <!-- 📷 Include Screenshots/Videos Demonstrating the Fix, New Feature, or the Behavior Before/After Breaking Changes. --> ## Version Control (Any Changes to the Plugin Will Require Bumping the Version) - [ ] I have Bumped Up the Version in Manifest.yaml (Top-Level `Version` Field, Not in Meta Section) <!-- ⚠️ NOTE: Version Format: MAJOR.MINOR.PATCH - MAJOR (0.x.x): Reserved for Significant architectural changes or incompatible API modifications - MINOR (x.0.x): For New feature additions while maintaining backward compatibility - PATCH (x.x.0): For Backward-compatible bug fixes and minor improvements - Note: Each Version Component (MAJOR, MINOR, PATCH) Can Be 2 Digits, e.g., 10.11.22 --> ## Dify Plugin SDK Version - [ ] I have Ensured `dify_plugin>=0.3.0,<0.6.0` is in requirements.txt ([SDK docs](https://github.com/langgenius/dify-plugin-sdks/blob/main/python/README.md)) ## Environment Verification (If Any Code Changes) <!-- ⚠️ NOTE: At Least One Environment Must Be Tested. --> ### Local Deployment Environment - [ ] Dify Version is: <!-- Specify Your Version (e.g., 1.2.0) -->, I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration. <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt - No Breaking Changes in Dify That May Affect the Testing Result --> ### SaaS Environment - [ ] I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration <!-- - Python Virtual Env Matching Manifest.yaml & requirements.txt --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 11:16:32 -05:00
yindo closed this issue 2026-02-16 11:16:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
dependencies
documentation
enhancement
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-official-plugins#2271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?