langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

GCS backend: concurrent uploads return 412 PreconditionFailed → daemon panics (v0.1.3-local) #162

New Issue
Open
opened 2026-02-16 00:20:13 -05:00 by yindo · 1 comment
yindo commented 2026-02-16 00:20:13 -05:00
Owner
Copy Link
Copy Source

Originally created by @furu-kaggle on GitHub (Jul 12, 2025).

Self Checks

To make sure we get to you in time, please check the following :)

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • "Please do not modify this template :) and fill in all the required fields."

Versions

  1. dify-plugin-daemon Version
    0.1.3-local
  2. dify-api Version
    v1.5.1 (Docker image langgenius/dify:1.5.1)

Describe the bug

With the Google Cloud Storage backend enabled, the daemon tries to upload the same plugin asset twice within ~300 ms.
The second write carries ifGenerationMatch=0 (added by storage.Conditions{DoesNotExist:true}), so GCS returns HTTP 412 Precondition Failed.
The 412 propagates unhandled and triggers an assertion error, which terminates the process.
Cloud Run restarts the container, but the new instance hits the same assertion again → infinite restart loop; the daemon never finishes initialisation.

To Reproduce

  1. Deploy one replica of dify-plugin-daemon:0.1.3-local with GCS storage.
   maxInstances: 1
   containerConcurrency: 1
  1. Cold-start the revision.
  2. Two storage.objects.create calls appear in Cloud Audit Log for the same key within ~1 s; the second ends in 412 PRECONDITION_FAILED.
  3. The pod exits on an assertion error; Cloud Run restarts it; the loop continues indefinitely.

Expected behavior

plugin-daemon should treat “object already exists” (HTTP 412) as an idempotent success, skip the duplicate upload, and continue initialisation instead of stopping on an assertion failure.

Screenshots / Logs

Image

Additional context

  • Failing code in dify-cloud-kit/oss/gcsblob/gcs.go → Save():

    obj = obj.If(storage.Conditions{DoesNotExist:true})  // adds ifGenerationMatch=0
if err := wc.Close(); err != nil {                   // 412 here
    return err                                       // bubbles up, triggers assertion
}

  • Minimal fix suggestion – intercept 412 and treat as already-exists:

    if err := wc.Close(); err != nil {
    if gErr, ok := err.(*googleapi.Error); ok && gErr.Code == http.StatusPreconditionFailed {
        return nil // idempotent success
    }
    return err
}

(Removing DoesNotExist:true would also work but drops the immutability guard.)

Happy to open a PR if this direction is acceptable. 🙂

::contentReference[oaicite:0]{index=0}
Originally created by @furu-kaggle on GitHub (Jul 12, 2025). **Self Checks** To make sure we get to you in time, please check the following :) - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify-plugin-daemon/issues), including closed ones. - [x] I confirm that I am using English to submit this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). - [x] "Please do not modify this template :) and fill in all the required fields." --- ### **Versions** 1. **dify-plugin-daemon Version** `0.1.3-local` 2. **dify-api Version** `v1.5.1` (Docker image `langgenius/dify:1.5.1`) --- ### **Describe the bug** With the **Google Cloud Storage backend** enabled, the daemon tries to upload the *same* plugin asset twice within ~300 ms. The second write carries `ifGenerationMatch=0` (added by `storage.Conditions{DoesNotExist:true}`), so GCS returns **HTTP 412 Precondition Failed**. The 412 propagates unhandled and triggers an **assertion error**, which terminates the process. Cloud Run restarts the container, but the new instance hits the same assertion again → **infinite restart loop**; the daemon never finishes initialisation. --- ### **To Reproduce** 1. Deploy **one** replica of `dify-plugin-daemon:0.1.3-local` with GCS storage. ```yaml maxInstances: 1 containerConcurrency: 1 ```` 2. Cold-start the revision. 3. Two `storage.objects.create` calls appear in Cloud Audit Log for the same key within \~1 s; the second ends in **412 PRECONDITION\_FAILED**. 4. The pod exits on an *assertion error*; Cloud Run restarts it; the loop continues indefinitely. --- ### **Expected behavior** `plugin-daemon` should treat **“object already exists”** (HTTP 412) as an *idempotent success*, skip the duplicate upload, and continue initialisation instead of stopping on an assertion failure. --- ### **Screenshots / Logs** <img width="2048" height="155" alt="Image" src="https://github.com/user-attachments/assets/acf12c50-649c-49d2-be2e-a6c197a146e9" /> --- ### **Additional context** * Failing code in **`dify-cloud-kit/oss/gcsblob/gcs.go` → `Save()`**: ```go obj = obj.If(storage.Conditions{DoesNotExist:true}) // adds ifGenerationMatch=0 if err := wc.Close(); err != nil { // 412 here return err // bubbles up, triggers assertion } ``` * **Minimal fix suggestion** – intercept 412 and treat as already-exists: ```go if err := wc.Close(); err != nil { if gErr, ok := err.(*googleapi.Error); ok && gErr.Code == http.StatusPreconditionFailed { return nil // idempotent success } return err } ``` (Removing `DoesNotExist:true` would also work but drops the immutability guard.) Happy to open a PR if this direction is acceptable. 🙂 ``` ::contentReference[oaicite:0]{index=0}
yindo commented 2026-02-16 00:20:14 -05:00
Author
Owner
Copy Link
Copy Source

@michel-devops commented on GitHub (Aug 14, 2025):

I second this. I couldn't get plugin-daemon to work with a GCS bucket. I see the same error as furu-kaggle, and also the following message in the logs:

2025/08/15 01:56:03 installed_bucket.go:81: [ERROR]failed to create PluginUniqueIdentifier from path plugin_packages/langgenius/openai:0.2.3@5a7f82fa86e28332ad51941d0b491c1e8a38ead539656442f7bf4c6129cd15fa: plugin_unique_identifier is not valid: _packages/langgenius/openai:0.2.3@5a7f82fa86e28332ad51941d0b491c1e8a38ead539656442f7bf4c6129cd15fa

@michel-devops commented on GitHub (Aug 14, 2025): I second this. I couldn't get plugin-daemon to work with a GCS bucket. I see the same error as [furu-kaggle](https://github.com/furu-kaggle), and also the following message in the logs: `2025/08/15 01:56:03 installed_bucket.go:81: [ERROR]failed to create PluginUniqueIdentifier from path plugin_packages/langgenius/openai:0.2.3@5a7f82fa86e28332ad51941d0b491c1e8a38ead539656442f7bf4c6129cd15fa: plugin_unique_identifier is not valid: _packages/langgenius/openai:0.2.3@5a7f82fa86e28332ad51941d0b491c1e8a38ead539656442f7bf4c6129cd15fa `
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?