langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #12] [MERGED] fix self.session.delete alway success #258

New Issue
Closed
opened 2026-02-16 01:15:16 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:16 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/12
Author: @hjlarry
Created: 1/17/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @Yeuoly

Base: main ← Head: p4

📝 Commits (5)

  • 1fbafdf fix self.session.delete alway success
  • 89cc5d8 fix save data always failed
  • 3ab44fd Merge branch 'p10' into p4
  • db33d80 redis delete response deleted item num
  • 9508873 add deleted num to invocate response

📊 Changes

12 files changed (+37 additions, -38 deletions)

View changed files

📝 internal/cluster/clutser_test.go (+1 -1)
📝 internal/core/persistence/persistence.go (+11 -8)
📝 internal/core/persistence/persistence_test.go (+1 -1)
📝 internal/core/plugin_daemon/backwards_invocation/task.go (+4 -2)
📝 internal/core/session_manager/session.go (+1 -1)
📝 internal/db/cache.go (+2 -2)
📝 internal/service/install_service/state.go (+4 -3)
📝 internal/types/models/curd/atomic.go (+3 -2)
📝 internal/utils/cache/redis.go (+5 -13)
📝 internal/utils/cache/redis_auto_type.go (+2 -2)
📝 internal/utils/cache/redis_auto_type_test.go (+2 -2)
📝 internal/utils/cache/redis_test.go (+1 -1)

📄 Description

currently, self.session.delete will always response SUCCESS, even when the key is not exist.

In redis, the del command will response how many keys were deleted, it will never raise redis.Nil.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/12 **Author:** [@hjlarry](https://github.com/hjlarry) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `p4` --- ### 📝 Commits (5) - [`1fbafdf`](https://github.com/langgenius/dify-plugin-daemon/commit/1fbafdf31125480d699040810c5e8a87bac141e9) fix self.session.delete alway success - [`89cc5d8`](https://github.com/langgenius/dify-plugin-daemon/commit/89cc5d8d6acf533e7767c82f3b0fc32d9e7ecb9d) fix save data always failed - [`3ab44fd`](https://github.com/langgenius/dify-plugin-daemon/commit/3ab44fd4a6c4408fb4fca2f6aaf4f9e7ba2224cb) Merge branch 'p10' into p4 - [`db33d80`](https://github.com/langgenius/dify-plugin-daemon/commit/db33d8084d6561b84a2e06e59c7aa937c3f34885) redis delete response deleted item num - [`9508873`](https://github.com/langgenius/dify-plugin-daemon/commit/9508873dfe0f04fb427153471779059df994b538) add deleted num to invocate response ### 📊 Changes **12 files changed** (+37 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `internal/cluster/clutser_test.go` (+1 -1) 📝 `internal/core/persistence/persistence.go` (+11 -8) 📝 `internal/core/persistence/persistence_test.go` (+1 -1) 📝 `internal/core/plugin_daemon/backwards_invocation/task.go` (+4 -2) 📝 `internal/core/session_manager/session.go` (+1 -1) 📝 `internal/db/cache.go` (+2 -2) 📝 `internal/service/install_service/state.go` (+4 -3) 📝 `internal/types/models/curd/atomic.go` (+3 -2) 📝 `internal/utils/cache/redis.go` (+5 -13) 📝 `internal/utils/cache/redis_auto_type.go` (+2 -2) 📝 `internal/utils/cache/redis_auto_type_test.go` (+2 -2) 📝 `internal/utils/cache/redis_test.go` (+1 -1) </details> ### 📄 Description currently, `self.session.delete` will always response `SUCCESS`, even when the key is not exist. In redis, the `del` command will response how many keys were deleted, it will never raise `redis.Nil`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:16 -05:00
yindo closed this issue 2026-02-16 01:15:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#258
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?