langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #23] [MERGED] support AWS credentials from IAM role #265

New Issue
Closed
opened 2026-02-16 01:15:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:18 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/23
Author: @tmokmss
Created: 1/31/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @Yeuoly

Base: main ← Head: aws-creds-from-env

📝 Commits (4)

  • 8b19d54 remove validation for aws access keys
  • 9eb4ec6 read credentials from environment variables
  • 3668db4 Merge branch 'main' into aws-creds-from-env
  • 823f088 validation for aws region

📊 Changes

2 files changed (+22 additions, -12 deletions)

View changed files

📝 internal/oss/s3/s3_storage.go (+20 -10)
📝 internal/types/app/config.go (+2 -2)

📄 Description

Currently only static IAM credentials are supported to access S3 buckets. It would be great if we could use IAM role credentials when running Dify on AWS, just like Dify itself. This PR enables it.

I found adding unit test for this difficult but let me know if you think it is required 🙏 At least I E2E-tested on my AWS environment.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/23 **Author:** [@tmokmss](https://github.com/tmokmss) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `aws-creds-from-env` --- ### 📝 Commits (4) - [`8b19d54`](https://github.com/langgenius/dify-plugin-daemon/commit/8b19d5496416bcc7ac4b484a29426c0c02300323) remove validation for aws access keys - [`9eb4ec6`](https://github.com/langgenius/dify-plugin-daemon/commit/9eb4ec681cb38f38df303a2ee37b91a716778278) read credentials from environment variables - [`3668db4`](https://github.com/langgenius/dify-plugin-daemon/commit/3668db43862bf080199c9d894394fee69c2f6306) Merge branch 'main' into aws-creds-from-env - [`823f088`](https://github.com/langgenius/dify-plugin-daemon/commit/823f08805b582fad232acbf0304ef28eb812cdb0) validation for aws region ### 📊 Changes **2 files changed** (+22 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `internal/oss/s3/s3_storage.go` (+20 -10) 📝 `internal/types/app/config.go` (+2 -2) </details> ### 📄 Description Currently only static IAM credentials are supported to access S3 buckets. It would be great if we could use IAM role credentials when running Dify on AWS, just [like Dify itself](https://github.com/langgenius/dify/blob/56e15d09a9e94de963dd5fc38c7455a7aaee99f3/api/extensions/storage/aws_s3_storage.py#L18-L36). This PR enables it. I found adding unit test for this difficult but let me know if you think it is required 🙏 At least I E2E-tested on my AWS environment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:18 -05:00
yindo closed this issue 2026-02-16 01:15:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?