langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-22 01:35:24 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #36] [MERGED] fix: plugins are not installed when plugin-daemon is restarted and plugins are stored on s3 #271

New Issue
Closed
opened 2026-02-16 01:15:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/36
Author: @tmokmss
Created: 2/26/2025
Status: ✅ Merged
Merged: 3/7/2025
Merged by: @Yeuoly

Base: main ← Head: fix-installation-from-s3

📝 Commits (1)

  • 7b94a8e fix: plugins are not installed when plugin-daemon is restarted and plugins are stored on s3

📊 Changes

2 files changed (+10 additions, -11 deletions)

View changed files

📝 internal/core/plugin_manager/media_transport/installed_bucket.go (+0 -9)
📝 internal/oss/local/local_storage.go (+10 -2)

📄 Description

closes #35
closes https://github.com/langgenius/dify/issues/14769
closes https://github.com/langgenius/dify/issues/14534
I moved the exists operation from installedBucket.List to localStorage.List. This makes the exist function for S3 storage no longer called, fixing the issue without changing any existing behavior for localStorage.

Since some implementation of storage does not require to check the existence of a directory before list operation, I believe it makes more sense to run an exists function inside a list function of each implementation, instead of handling it from caller.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/36 **Author:** [@tmokmss](https://github.com/tmokmss) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `fix-installation-from-s3` --- ### 📝 Commits (1) - [`7b94a8e`](https://github.com/langgenius/dify-plugin-daemon/commit/7b94a8e925e9f29da28f63750d849d10ecb55688) fix: plugins are not installed when plugin-daemon is restarted and plugins are stored on s3 ### 📊 Changes **2 files changed** (+10 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/plugin_manager/media_transport/installed_bucket.go` (+0 -9) 📝 `internal/oss/local/local_storage.go` (+10 -2) </details> ### 📄 Description closes #35 closes https://github.com/langgenius/dify/issues/14769 closes https://github.com/langgenius/dify/issues/14534 I moved the exists operation from installedBucket.List to localStorage.List. This makes the exist function for S3 storage no longer called, fixing the issue without changing any existing behavior for localStorage. Since some implementation of storage does not require to check the existence of a directory before list operation, I believe it makes more sense to run an exists function inside a list function of each implementation, instead of handling it from caller. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:20 -05:00
yindo closed this issue 2026-02-16 01:15:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?