[PR #72] [MERGED] fix: prevent potential deadlock in stdio handler listener invocation #294

Closed
opened 2026-02-16 01:15:25 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/72
Author: @Yeuoly
Created: 3/7/2025
Status: Merged
Merged: 3/7/2025
Merged by: @Yeuoly

Base: mainHead: fix/deadlock


📝 Commits (1)

  • ea5732a fix: prevent potential deadlock in stdio handler listener invocation

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 internal/core/plugin_manager/local_runtime/stdio_handle.go (+11 -2)

📄 Description

Modify stdout listener handling to avoid potential deadlocks by:

  • Copying listeners before invocation
  • Executing listener callbacks outside of the lock
  • Separating listener retrieval and execution steps

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/72 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `fix/deadlock` --- ### 📝 Commits (1) - [`ea5732a`](https://github.com/langgenius/dify-plugin-daemon/commit/ea5732a3dc0605041c2869646b6236fbcc4b8020) fix: prevent potential deadlock in stdio handler listener invocation ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/plugin_manager/local_runtime/stdio_handle.go` (+11 -2) </details> ### 📄 Description Modify stdout listener handling to avoid potential deadlocks by: - Copying listeners before invocation - Executing listener callbacks outside of the lock - Separating listener retrieval and execution steps --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:25 -05:00
yindo closed this issue 2026-02-16 01:15:25 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#294