langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #198] [MERGED] refactor(plugin_manager): replace stdio handling with stdioHolder for improved management and cleanup #364

New Issue
Closed
opened 2026-02-16 01:15:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:44 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/198
Author: @Yeuoly
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @Yeuoly

Base: main ← Head: refactor/stdip

📝 Commits (2)

  • 51ba82a refactor(plugin_manager): replace stdio handling with stdioHolder for improved management and cleanup
  • 40ac75b feat(plugin_manager): add tests for stdioHolder functionality and enhance error handling

📊 Changes

9 files changed (+515 additions, -145 deletions)

View changed files

📝 go.mod (+2 -0)
➕ internal/core/plugin_manager/graceful_shutdown_test.go (+1 -0)
➕ internal/core/plugin_manager/local_launch_test.go (+1 -0)
📝 internal/core/plugin_manager/local_runtime/io.go (+3 -3)
📝 internal/core/plugin_manager/local_runtime/run.go (+11 -19)
📝 internal/core/plugin_manager/local_runtime/stdio.go (+51 -20)
➖ internal/core/plugin_manager/local_runtime/stdio_store.go (+0 -101)
➕ internal/core/plugin_manager/local_runtime/stdio_test.go (+443 -0)
📝 internal/core/plugin_manager/local_runtime/type.go (+3 -2)

📄 Description

  • Introduced stdioHolder to encapsulate stdio operations, enhancing modularity.
  • Updated LocalPluginRuntime methods to utilize stdioHolder for event listening and error handling.
  • Removed legacy stdio handling functions to streamline the codebase.
  • Added tests for stdio handler

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/198 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `refactor/stdip` --- ### 📝 Commits (2) - [`51ba82a`](https://github.com/langgenius/dify-plugin-daemon/commit/51ba82a15d575a465fc710fcbb1af3ef657d634f) refactor(plugin_manager): replace stdio handling with stdioHolder for improved management and cleanup - [`40ac75b`](https://github.com/langgenius/dify-plugin-daemon/commit/40ac75b0a60cf216335772940e6ea193e0b0bbb6) feat(plugin_manager): add tests for stdioHolder functionality and enhance error handling ### 📊 Changes **9 files changed** (+515 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+2 -0) ➕ `internal/core/plugin_manager/graceful_shutdown_test.go` (+1 -0) ➕ `internal/core/plugin_manager/local_launch_test.go` (+1 -0) 📝 `internal/core/plugin_manager/local_runtime/io.go` (+3 -3) 📝 `internal/core/plugin_manager/local_runtime/run.go` (+11 -19) 📝 `internal/core/plugin_manager/local_runtime/stdio.go` (+51 -20) ➖ `internal/core/plugin_manager/local_runtime/stdio_store.go` (+0 -101) ➕ `internal/core/plugin_manager/local_runtime/stdio_test.go` (+443 -0) 📝 `internal/core/plugin_manager/local_runtime/type.go` (+3 -2) </details> ### 📄 Description - Introduced stdioHolder to encapsulate stdio operations, enhancing modularity. - Updated LocalPluginRuntime methods to utilize stdioHolder for event listening and error handling. - Removed legacy stdio handling functions to streamline the codebase. - Added tests for stdio handler --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:15:44 -05:00
yindo closed this issue 2026-02-16 01:15:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#364
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?