[PR #340] [MERGED] add USE_AWS_S3 args avoid ambiguity. #455

Closed
opened 2026-02-16 01:16:01 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/340
Author: @41tair
Created: 6/10/2025
Status: Merged
Merged: 6/11/2025
Merged by: @41tair

Base: mainHead: add-s3-use-iam-args


📝 Commits (1)

  • 43eea04 add USE_AWS_S3 args avoid ambiguity.

📊 Changes

5 files changed (+9 additions, -4 deletions)

View changed files

📝 .env.example (+2 -1)
📝 go.mod (+1 -1)
📝 go.sum (+2 -0)
📝 internal/server/server.go (+2 -1)
📝 internal/types/app/config.go (+2 -1)

📄 Description

Previously, we used the S3_USE_AWS_MANAGED_IAM environment variable, passing it to a UseAws argument to determine whether to use the AWS S3 API. This approach was confusing.

Now, we have introduced a new variable, USE_AWS_S3, to control this behavior. The original S3_USE_AWS_MANAGED_IAM variable will now be used for its intended purpose: to determine how to authorize S3 API requests.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/340 **Author:** [@41tair](https://github.com/41tair) **Created:** 6/10/2025 **Status:** ✅ Merged **Merged:** 6/11/2025 **Merged by:** [@41tair](https://github.com/41tair) **Base:** `main` ← **Head:** `add-s3-use-iam-args` --- ### 📝 Commits (1) - [`43eea04`](https://github.com/langgenius/dify-plugin-daemon/commit/43eea04d0d183d929e992ce2e8f7422089b5fcbd) add USE_AWS_S3 args avoid ambiguity. ### 📊 Changes **5 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+2 -1) 📝 `go.mod` (+1 -1) 📝 `go.sum` (+2 -0) 📝 `internal/server/server.go` (+2 -1) 📝 `internal/types/app/config.go` (+2 -1) </details> ### 📄 Description Previously, we used the **S3_USE_AWS_MANAGED_IAM** environment variable, passing it to a **UseAws** argument to determine whether to use the AWS S3 API. This approach was confusing. Now, we have introduced a new variable, **USE_AWS_S3**, to control this behavior. The original **S3_USE_AWS_MANAGED_IAM** variable will now be used for its intended purpose: to determine how to authorize S3 API requests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:01 -05:00
yindo closed this issue 2026-02-16 01:16:01 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#455