[PR #392] [MERGED] feat(plugin_manager): dark icons #482

Closed
opened 2026-02-16 01:16:06 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/392
Author: @Yeuoly
Created: 7/9/2025
Status: Merged
Merged: 7/9/2025
Merged by: @Yeuoly

Base: mainHead: feat/icon-dark


📝 Commits (1)

  • 6787491 feat(plugin_manager): enhance asset remapping for icons

📊 Changes

3 files changed (+45 additions, -52 deletions)

View changed files

📝 internal/core/plugin_manager/media_transport/assets.go (+42 -52)
📝 pkg/entities/plugin_entities/model_declaration.go (+2 -0)
📝 pkg/entities/plugin_entities/tool_declaration.go (+1 -0)

📄 Description

Description

  • Refactored the RemapAssets function to streamline the remapping of icon fields for both models and tools, including support for dark mode icons.
  • Introduced new fields IconSmallDark and IconLargeDark in the ModelProviderDeclaration and added IconDark in ToolProviderIdentity to accommodate dark mode assets.
  • Improved error handling during the remapping process for better clarity and maintainability.

Related PRs:

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/392 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 7/9/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `feat/icon-dark` --- ### 📝 Commits (1) - [`6787491`](https://github.com/langgenius/dify-plugin-daemon/commit/678749106cea40c9a2e93c1ac8a11854731f5bda) feat(plugin_manager): enhance asset remapping for icons ### 📊 Changes **3 files changed** (+45 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/plugin_manager/media_transport/assets.go` (+42 -52) 📝 `pkg/entities/plugin_entities/model_declaration.go` (+2 -0) 📝 `pkg/entities/plugin_entities/tool_declaration.go` (+1 -0) </details> ### 📄 Description ## Description - Refactored the RemapAssets function to streamline the remapping of icon fields for both models and tools, including support for dark mode icons. - Introduced new fields IconSmallDark and IconLargeDark in the ModelProviderDeclaration and added IconDark in ToolProviderIdentity to accommodate dark mode assets. - Improved error handling during the remapping process for better clarity and maintainability. Related PRs: - https://github.com/langgenius/dify-plugin-sdks/pull/173/ ## Type of Change - [ ] Bug fix - [ ] New feature - [ ] Refactor - [ ] Performance improvement - [ ] Other ## Essential Checklist ### Testing - [ ] I have tested the changes locally and confirmed they work as expected - [ ] I have added unit tests where necessary and they pass successfully ### Bug Fix (if applicable) - [ ] I have used GitHub syntax to close the related issue (e.g., `Fixes #123` or `Closes #123`) ## Additional Information Please provide any additional context that would help reviewers understand the changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:06 -05:00
yindo closed this issue 2026-02-16 01:16:06 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#482