langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #389] [CLOSED] fix(gcs): Check Exists before Save in OSS to avoid Conditions{Doe… #484

New Issue
Closed
opened 2026-02-16 01:16:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:06 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/389
Author: @ThreeFish-AI
Created: 7/7/2025
Status: ❌ Closed

Base: main ← Head: master

📝 Commits (1)

  • 86f0b8a fix(gcs): Check Exists before Save in OSS to avoid Conditions{DoesNotExist} check exception

📊 Changes

4 files changed (+22 additions, -4 deletions)

View changed files

📝 internal/core/persistence/wrapper.go (+5 -0)
📝 internal/core/plugin_manager/media_transport/assets_bucket.go (+5 -2)
📝 internal/core/plugin_manager/media_transport/installed_bucket.go (+7 -1)
📝 internal/core/plugin_manager/media_transport/package_bucket.go (+5 -1)

📄 Description

…sNotExist} check exception

Description

Check Exists before Save in OSS to avoid Conditions{DoesNotExist} check exception.

Context: When using GCS for resource storage, resources that already exist on GCS will directly return an error when saving for the second time. Normally, it should return a successful save if the resources already exist.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/389 **Author:** [@ThreeFish-AI](https://github.com/ThreeFish-AI) **Created:** 7/7/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `master` --- ### 📝 Commits (1) - [`86f0b8a`](https://github.com/langgenius/dify-plugin-daemon/commit/86f0b8a1386dc8920d16ec292547c98392d4690b) fix(gcs): Check `Exists` before `Save` in OSS to avoid Conditions{DoesNotExist} check exception ### 📊 Changes **4 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/persistence/wrapper.go` (+5 -0) 📝 `internal/core/plugin_manager/media_transport/assets_bucket.go` (+5 -2) 📝 `internal/core/plugin_manager/media_transport/installed_bucket.go` (+7 -1) 📝 `internal/core/plugin_manager/media_transport/package_bucket.go` (+5 -1) </details> ### 📄 Description …sNotExist} check exception ## Description Check `Exists` before `Save` in OSS to avoid Conditions{DoesNotExist} check exception. Context: When using GCS for resource storage, resources that already exist on GCS will directly return an error when saving for the second time. Normally, it should return a successful save if the resources already exist. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Refactor - [ ] Performance improvement - [ ] Other ## Essential Checklist ### Testing - [x] I have tested the changes locally and confirmed they work as expected - [ ] I have added unit tests where necessary and they pass successfully ### Bug Fix (if applicable) - [ ] I have used GitHub syntax to close the related issue (e.g., `Fixes #123` or `Closes #123`) ## Additional Information Please provide any additional context that would help reviewers understand the changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:06 -05:00
yindo closed this issue 2026-02-16 01:16:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?