langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #413] [MERGED] refactor(session_manager): update GetSession function to return error #497

New Issue
Closed
opened 2026-02-16 01:16:09 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:09 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/413
Author: @Yeuoly
Created: 7/24/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @Yeuoly

Base: main ← Head: fix/sessions-log

📝 Commits (1)

  • d52a9ce refactor(session_manager): update GetSession function to return error

📊 Changes

3 files changed (+8 additions, -11 deletions)

View changed files

📝 internal/core/plugin_daemon/backwards_invocation/task.go (+0 -2)
📝 internal/core/plugin_daemon/backwards_invocation/transaction/aws_event_handler.go (+4 -4)
📝 internal/core/session_manager/session.go (+4 -5)

📄 Description

  • Modified GetSession to return an error alongside the session, improving error handling when a session is not found.
  • Updated invocation of GetSession in AWS event handler to handle the new error return value.
  • Removed logging statements in favor of returning errors directly for better error propagation.

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/413 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 7/24/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `fix/sessions-log` --- ### 📝 Commits (1) - [`d52a9ce`](https://github.com/langgenius/dify-plugin-daemon/commit/d52a9cef4d35e20eb65bb7af34bf0eff84516215) refactor(session_manager): update GetSession function to return error ### 📊 Changes **3 files changed** (+8 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/plugin_daemon/backwards_invocation/task.go` (+0 -2) 📝 `internal/core/plugin_daemon/backwards_invocation/transaction/aws_event_handler.go` (+4 -4) 📝 `internal/core/session_manager/session.go` (+4 -5) </details> ### 📄 Description - Modified GetSession to return an error alongside the session, improving error handling when a session is not found. - Updated invocation of GetSession in AWS event handler to handle the new error return value. - Removed logging statements in favor of returning errors directly for better error propagation. ## Description Please provide a brief description of the changes made in this pull request. Please also include the issue number if this is related to an issue using the format `Fixes #123` or `Closes #123`. ## Type of Change - [ ] Bug fix - [ ] New feature - [ ] Refactor - [ ] Performance improvement - [ ] Other ## Essential Checklist ### Testing - [ ] I have tested the changes locally and confirmed they work as expected - [ ] I have added unit tests where necessary and they pass successfully ### Bug Fix (if applicable) - [ ] I have used GitHub syntax to close the related issue (e.g., `Fixes #123` or `Closes #123`) ## Additional Information Please provide any additional context that would help reviewers understand the changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:09 -05:00
yindo closed this issue 2026-02-16 01:16:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#497
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?