langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #430] [MERGED] chore: remove JSON schema validation from tool and agent services #502

New Issue
Closed
opened 2026-02-16 01:16:09 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:09 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/430
Author: @Yeuoly
Created: 8/26/2025
Status: ✅ Merged
Merged: 8/26/2025
Merged by: @Yeuoly

Base: main ← Head: chore/remove-json-schema-validation-error

📝 Commits (2)

  • 3c58032 chore: remove JSON schema validation from tool and agent services
  • 12c81a6 fix: remove duplicated routes

📊 Changes

11 files changed (+58 additions, -345 deletions)

View changed files

📝 internal/core/plugin_daemon/agent_service.go (+3 -90)
📝 internal/core/plugin_daemon/tool.gen.go (+13 -0)
➖ internal/core/plugin_daemon/tool_service.go (+0 -120)
➖ internal/core/plugin_daemon/tool_service_test.go (+0 -78)
📝 internal/server/controllers/definitions/definitions.go (+11 -11)
📝 internal/server/controllers/tool.gen.go (+13 -0)
📝 internal/server/controllers/tool.go (+0 -16)
📝 internal/server/http_server.gen.go (+1 -0)
📝 internal/server/http_server.go (+0 -1)
➖ internal/service/invoke_tool.go (+0 -29)
📝 internal/service/tool.gen.go (+17 -0)

📄 Description

  • Remove bindAgentStrategyValidator and bindToolValidator functions
  • Remove gojsonschema dependency
  • Simplify InvokeAgentStrategy by removing validation logic
  • Consolidate tool invocation into generated code
  • Remove redundant tool_service.go and related test files
  • Move InvokeTool to generated files for consistency

🤖 Generated with Claude Code

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/430 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 8/26/2025 **Status:** ✅ Merged **Merged:** 8/26/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `chore/remove-json-schema-validation-error` --- ### 📝 Commits (2) - [`3c58032`](https://github.com/langgenius/dify-plugin-daemon/commit/3c580324fa9021c39bc10e9630ca038d3c7e65a8) chore: remove JSON schema validation from tool and agent services - [`12c81a6`](https://github.com/langgenius/dify-plugin-daemon/commit/12c81a6a41724f645284d0e8c538ebfae8ac3d17) fix: remove duplicated routes ### 📊 Changes **11 files changed** (+58 additions, -345 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/plugin_daemon/agent_service.go` (+3 -90) 📝 `internal/core/plugin_daemon/tool.gen.go` (+13 -0) ➖ `internal/core/plugin_daemon/tool_service.go` (+0 -120) ➖ `internal/core/plugin_daemon/tool_service_test.go` (+0 -78) 📝 `internal/server/controllers/definitions/definitions.go` (+11 -11) 📝 `internal/server/controllers/tool.gen.go` (+13 -0) 📝 `internal/server/controllers/tool.go` (+0 -16) 📝 `internal/server/http_server.gen.go` (+1 -0) 📝 `internal/server/http_server.go` (+0 -1) ➖ `internal/service/invoke_tool.go` (+0 -29) 📝 `internal/service/tool.gen.go` (+17 -0) </details> ### 📄 Description - Remove bindAgentStrategyValidator and bindToolValidator functions - Remove gojsonschema dependency - Simplify InvokeAgentStrategy by removing validation logic - Consolidate tool invocation into generated code - Remove redundant tool_service.go and related test files - Move InvokeTool to generated files for consistency 🤖 Generated with [Claude Code](https://claude.ai/code) ## Description Please provide a brief description of the changes made in this pull request. Please also include the issue number if this is related to an issue using the format `Fixes #123` or `Closes #123`. ## Type of Change - [ ] Bug fix - [ ] New feature - [x] Refactor - [ ] Performance improvement - [ ] Other ## Essential Checklist ### Testing - [ ] I have tested the changes locally and confirmed they work as expected - [ ] I have added unit tests where necessary and they pass successfully ### Bug Fix (if applicable) - [ ] I have used GitHub syntax to close the related issue (e.g., `Fixes #123` or `Closes #123`) ## Additional Information Please provide any additional context that would help reviewers understand the changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:09 -05:00
yindo closed this issue 2026-02-16 01:16:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#502
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?