langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #467] [MERGED] fix: validate plugin manifest on package upload #523

New Issue
Closed
opened 2026-02-16 01:16:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:13 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/467
Author: @Yeuoly
Created: 9/29/2025
Status: ✅ Merged
Merged: 9/29/2025
Merged by: @Mairuis

Base: main ← Head: codex/add-manifest-check-to-upload-endpoint

📝 Commits (1)

  • ff32fc7 Check manifest when saving plugin packages

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 internal/core/plugin_manager/manager.go (+4 -0)

📄 Description

Summary

  • ensure plugin package uploads validate manifests via ManifestValidate before saving
  • surface an error for illegal manifests so upload endpoints reject bad packages

Testing

  • go test ./... (fails: internal/core/license/private_key/key.go:5:12: pattern PRIVATE_KEY.pem: no matching files found)

https://chatgpt.com/codex/tasks/task_b_68da25048b188326b404db3efeb065f4

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/467 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 9/29/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@Mairuis](https://github.com/Mairuis) **Base:** `main` ← **Head:** `codex/add-manifest-check-to-upload-endpoint` --- ### 📝 Commits (1) - [`ff32fc7`](https://github.com/langgenius/dify-plugin-daemon/commit/ff32fc7b0cb1b6ae8cd886bec494d2f83a849be5) Check manifest when saving plugin packages ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/plugin_manager/manager.go` (+4 -0) </details> ### 📄 Description ## Summary - ensure plugin package uploads validate manifests via ManifestValidate before saving - surface an error for illegal manifests so upload endpoints reject bad packages ## Testing - go test ./... *(fails: internal/core/license/private_key/key.go:5:12: pattern PRIVATE_KEY.pem: no matching files found)* ------ https://chatgpt.com/codex/tasks/task_b_68da25048b188326b404db3efeb065f4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:13 -05:00
yindo closed this issue 2026-02-16 01:16:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?