langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #537] [MERGED] fix: plugin log not display after refactor #569

New Issue
Closed
opened 2026-02-16 01:16:21 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:21 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/537
Author: @hjlarry
Created: 12/14/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @Yeuoly

Base: main ← Head: p18

📝 Commits (3)

  • c76c415 fix: plugin log not display after refactor
  • 79d3692 Update internal/core/local_runtime/notifier_logger.go
  • 00b6944 feat: add logging support for local runtime instance events

📊 Changes

15 files changed (+95 additions, -81 deletions)

View changed files

📝 internal/core/control_panel/launcher_local.go (+5 -0)
📝 internal/core/control_panel/logger.go (+29 -0)
📝 internal/core/control_panel/signals.go (+6 -0)
📝 internal/core/debugging_runtime/lifetime.go (+1 -3)
📝 internal/core/io_tunnel/backwards_invocation/transaction/aws_event_handler.go (+1 -1)
📝 internal/core/local_runtime/instance.go (+6 -2)
📝 internal/core/local_runtime/notifier_lifecycle.go (+3 -1)
➖ internal/core/local_runtime/notifier_logger.go (+0 -67)
📝 internal/core/local_runtime/signals_instance.go (+3 -1)
📝 internal/core/local_runtime/signals_runtime.go (+5 -0)
📝 internal/core/local_runtime/signals_template.go (+18 -3)
📝 internal/core/local_runtime/subprocess.go (+6 -0)
📝 internal/core/serverless_runtime/io.go (+1 -1)
📝 internal/service/install_service/controlpanel.go (+7 -0)
📝 pkg/entities/plugin_entities/event.go (+4 -2)

📄 Description

Description

The missing logs were likely caused by NotifierLogger not being added in internal/core/local_runtime/subprocess.go. Additionally, I've updated the OnInstanceLog method's parameters to support various log display levels.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

image
  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/537 **Author:** [@hjlarry](https://github.com/hjlarry) **Created:** 12/14/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `p18` --- ### 📝 Commits (3) - [`c76c415`](https://github.com/langgenius/dify-plugin-daemon/commit/c76c4154feab21ceaadecdf520a7c447e3574dfe) fix: plugin log not display after refactor - [`79d3692`](https://github.com/langgenius/dify-plugin-daemon/commit/79d369234fb7653069fff7b19bc94522dc12116d) Update internal/core/local_runtime/notifier_logger.go - [`00b6944`](https://github.com/langgenius/dify-plugin-daemon/commit/00b6944ede4670fb0b6b8d05098abcb9c62c7e30) feat: add logging support for local runtime instance events ### 📊 Changes **15 files changed** (+95 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/control_panel/launcher_local.go` (+5 -0) 📝 `internal/core/control_panel/logger.go` (+29 -0) 📝 `internal/core/control_panel/signals.go` (+6 -0) 📝 `internal/core/debugging_runtime/lifetime.go` (+1 -3) 📝 `internal/core/io_tunnel/backwards_invocation/transaction/aws_event_handler.go` (+1 -1) 📝 `internal/core/local_runtime/instance.go` (+6 -2) 📝 `internal/core/local_runtime/notifier_lifecycle.go` (+3 -1) ➖ `internal/core/local_runtime/notifier_logger.go` (+0 -67) 📝 `internal/core/local_runtime/signals_instance.go` (+3 -1) 📝 `internal/core/local_runtime/signals_runtime.go` (+5 -0) 📝 `internal/core/local_runtime/signals_template.go` (+18 -3) 📝 `internal/core/local_runtime/subprocess.go` (+6 -0) 📝 `internal/core/serverless_runtime/io.go` (+1 -1) 📝 `internal/service/install_service/controlpanel.go` (+7 -0) 📝 `pkg/entities/plugin_entities/event.go` (+4 -2) </details> ### 📄 Description ## Description The missing logs were likely caused by `NotifierLogger` not being added in `internal/core/local_runtime/subprocess.go`. Additionally, I've updated the `OnInstanceLog` method's parameters to support various log display levels. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Refactor - [ ] Performance improvement - [ ] Other ## Essential Checklist ### Testing <img width="1516" height="356" alt="image" src="https://github.com/user-attachments/assets/518ccf74-277d-49d4-9e64-d016c6054537" /> - [x] I have tested the changes locally and confirmed they work as expected - [ ] I have added unit tests where necessary and they pass successfully ### Bug Fix (if applicable) - [ ] I have used GitHub syntax to close the related issue (e.g., `Fixes #123` or `Closes #123`) ## Additional Information Please provide any additional context that would help reviewers understand the changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:21 -05:00
yindo closed this issue 2026-02-16 01:16:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#569
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?